Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Updated unsplash setting migration to be idempotent

Browse source 
refs https://github.com/TryGhost/Ghost/issues/10318

- Previous version of migration was not following the idempotence rule of migrations
This commit is contained in:
Naz 2021-02-17 16:17:07 +13:00 • committed by naz
parent e0cc314f91
commit abb8c1df74
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/server/data/migrations/versions/4.0/20-refactor-unsplash-setting.js
View file

@ -2,6 +2,8 @@ const logging = require('../../../../../shared/logging');
const {createIrreversibleMigration} = require('../../utils'); const {createIrreversibleMigration} = require('../../utils');
module.exports = createIrreversibleMigration(async (knex) => { module.exports = createIrreversibleMigration(async (knex) => {
logging.info('Updating unsplash setting value');
const unsplashSetting = await knex('settings') const unsplashSetting = await knex('settings')
.select('value') .select('value')
.where({ .where({
@ -10,6 +12,12 @@ module.exports = createIrreversibleMigration(async (knex) => {
.first(); .first();
let isActive; let isActive;
if (unsplashSetting && (unsplashSetting.value === 'true' || unsplashSetting.value === 'false')) {
logging.warn(`Skipping update of unsplash value. Current value is already boolean: ${unsplashSetting.value}`);
return;
}
try { try {
const value = JSON.parse(unsplashSetting.value); const value = JSON.parse(unsplashSetting.value);
isActive = typeof value.isActive === 'boolean' ? value.isActive : true; isActive = typeof value.isActive === 'boolean' ? value.isActive : true;