From ab4493db5f8d4a4d04721239a6bccff7df093801 Mon Sep 17 00:00:00 2001 From: Fabien O'Carroll Date: Mon, 30 Sep 2019 12:04:49 +0700 Subject: [PATCH] Ensured falsy values are not set as cookies no-issue --- ghost/members-ssr/index.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ghost/members-ssr/index.js b/ghost/members-ssr/index.js index 0e85d00007..7894ada4e8 100644 --- a/ghost/members-ssr/index.js +++ b/ghost/members-ssr/index.js @@ -128,6 +128,9 @@ class MembersSSR { * @param {string} value */ _setSessionCookie(req, res, value) { + if (!value) { + return this._removeSessionCookie(req, res); + } const cookies = this._getCookies(req, res); cookies.set(this.sessionCookieName, value, this.sessionCookieOptions); } @@ -170,6 +173,9 @@ class MembersSSR { * @param {object} value */ _setCacheCookie(req, res, value) { + if (!value) { + return this._removeCacheCookie(req, res); + } const cookies = this._getCookies(req, res); cookies.set(this.cacheCookieName, JSON.stringify(value), this.cacheCookieOptions); }