From aacb30e35ef887f53f2972231b21cbe8189d74a7 Mon Sep 17 00:00:00 2001
From: Ghassan Maslamani <ghassan.maslamani@gmail.com>
Date: Thu, 28 Apr 2022 13:33:22 +0300
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20missing=20alt=20on=20AMP?=
 =?UTF-8?q?=20images=20(#14453)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

closes: #14440

- use best available values to provide alt tags on images in amp.hbs
- this prevents certain tools from reporting errors/warnings with our amp pages
---
 core/frontend/apps/amp/lib/views/amp.hbs | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/core/frontend/apps/amp/lib/views/amp.hbs b/core/frontend/apps/amp/lib/views/amp.hbs
index 0c11bc48dd..7d7844d84c 100644
--- a/core/frontend/apps/amp/lib/views/amp.hbs
+++ b/core/frontend/apps/amp/lib/views/amp.hbs
@@ -987,7 +987,7 @@
     <header class="page-header">
         <a href="{{@site.url}}">
             {{#if @site.icon}}
-                <amp-img class="site-icon" src="{{img_url @site.icon absolute="true"}}" width="50" height="50" layout="fixed"></amp-img>
+                <amp-img class="site-icon" src="{{img_url @site.icon absolute="true"}}" width="50" height="50" layout="fixed" alt="{{@site.title}}"></amp-img>
             {{else}}
                 {{@site.title}}
             {{/if}}
@@ -1006,7 +1006,9 @@
             </header>
             {{#if feature_image}}
             <figure class="post-image">
-                <amp-img src="{{img_url feature_image absolute="true"}}" width="600" height="340" layout="responsive"></amp-img>
+                <amp-img src="{{img_url feature_image absolute="true"}}" width="600" height="340" layout="responsive" 
+                alt="{{#if feature_image_alt}}{{feature_image_alt}}{{else}}{{title}}{{/if}}"
+                ></amp-img>
             </figure>
             {{/if}}
             <section class="post-content">
@@ -1020,7 +1022,7 @@
     {{/post}}
     <footer class="page-footer">
         {{#if @site.icon}}
-            <amp-img class="site-icon" src="{{img_url @site.icon absolute="true"}}" width="50" height="50" layout="fixed"></amp-img>
+            <amp-img class="site-icon" src="{{img_url @site.icon absolute="true"}}" width="50" height="50" layout="fixed" alt="{{@site.title}}"></amp-img>
         {{/if}}
         <h3>{{@site.title}}</h3>
         {{#if @site.description}}