From ffdbde8eedb869df9300e589aad26761c7b8b572 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Thu, 26 May 2022 12:39:15 +0100 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20editor=20cards=20som?= =?UTF-8?q?etimes=20being=20removed=20as=20soon=20as=20they=20are=20added?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit no issue When adding cards to the editor, especially image cards, we were seeing the cards removed instantaneously or whilst the file dialog was open making it appear that nothing had happened after selecting the card in the menu or selecting a file. - as part of the publish flow workflow we extracted the pre-save routine into a separate task so that it could be triggered from external components - one of the pre-save routine actions was to trigger an editor cleanup that removes empty cards and trailing paragraphs _but_ it should only do that when not performing a background save that occurs on any change to the post contents for drafts - the problem arose from the background saves because the `options` argument was never passed through to the `beforeSaveTask` call meaning every save looked like a full save and performed editor cleanup resulting in unexpected removal of empty cards that had just been created --- ghost/admin/app/controllers/editor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ghost/admin/app/controllers/editor.js b/ghost/admin/app/controllers/editor.js index 553dc39654..060366833c 100644 --- a/ghost/admin/app/controllers/editor.js +++ b/ghost/admin/app/controllers/editor.js @@ -468,7 +468,7 @@ export default class EditorController extends Controller { // new publishing flow sets the post status manually on publish this.set('post.status', status); - yield this.beforeSaveTask.perform(); + yield this.beforeSaveTask.perform(options); try { let post = yield this._savePostTask.perform(options); From bcde7970fb26860e3ea34861621f18b66c29f320 Mon Sep 17 00:00:00 2001 From: Daniel Lockyer Date: Thu, 26 May 2022 15:17:24 +0100 Subject: [PATCH 2/2] v5.0.2 --- ghost/admin/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ghost/admin/package.json b/ghost/admin/package.json index 2dbe926517..79c2a08fde 100644 --- a/ghost/admin/package.json +++ b/ghost/admin/package.json @@ -1,6 +1,6 @@ { "name": "ghost-admin", - "version": "5.0.1", + "version": "5.0.2", "description": "Ember.js admin client for Ghost", "author": "Ghost Foundation", "homepage": "http://ghost.org",