Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-04 02:01:58 -05:00
Code Issues Activity

Fixed failing type check in admin-x-design-system story (#20838)

Browse source 
no issue

- The type checks for `admin-x-design-system` were failing for me locally for a Storybook story. It looks like we changed the `PopoverPosition` type to use 'start'/'end' rather than 'left'/'right', but this story was still using 'left'. This was causing `yarn test` to fail in the `admin-x-design-system` app.
- This commit updates the story to use 'start' instead of 'left', which allows the type checks to pass.
This commit is contained in:
Chris Raible 2024-08-27 17:58:42 -07:00 • committed by GitHub
parent 962194b595
commit a79ab03463
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/admin-x-design-system/src/global/SortMenu.stories.tsx
View file

@ -22,7 +22,7 @@ export const Default: Story = {
items: items,
onSortChange: () => {},
onDirectionChange: () => {},
position: 'left'
position: 'start'
},
decorators: [
ThisStory => (