Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-17 23:44:39 -05:00
Code Issues Activity

Added in min and max values to the Paid Mix chart to maintain width

Browse source 
refs: https://github.com/TryGhost/Team/issues/1531
This commit is contained in:
James Morris 2022-05-12 14:35:30 +01:00
parent 793b192199
commit a6b4dbc353
1 changed files with 35 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
ghost/admin/app/components/dashboard/v5/charts/paid-mix.js
View file

@ -367,32 +367,52 @@ export default class PaidMix extends Component {
get chartOptions() {
let that = this;
let ticksY;
let ticksY = {display: false};
let totalCadence = this.dashboardStats.paidMembersByCadence.month + this.dashboardStats.paidMembersByCadence.year;
let minTickValue = -(Math.round(this.dashboardStats.paidMembersByCadence.month / totalCadence * 100));
let maxTickValue = Math.round(this.dashboardStats.paidMembersByCadence.year / totalCadence * 100);
// this is for cadence...
if (this.mode === 'cadence') {
// for when it's empty
if (totalCadence === 0) {
minTickValue = -50;
maxTickValue = 50;
ticksY = {
display: false,
min: minTickValue,
max: maxTickValue
};
// when it does have data
} else {
ticksY = {
display: false,
min: minTickValue,
max: maxTickValue
};
}
} else {
ticksY = {
display: false
display: false,
min: minTickValue,
max: maxTickValue
};
// this is for tiers...
} else {
let tierPercentages = [];
let data = this.dashboardStats.paidMembersByTier.map(stat => stat.members);
let totalTiersAmount = 0;
for (let i = 0; i < data.length; i++) {
totalTiersAmount += data[i];
}
for (let i = 0; i < data.length; i++) {
let tierPercentage = Math.round(data[i] / totalTiersAmount * 100);
if (i === 0) {
tierPercentage = -tierPercentage;
}
tierPercentages.push(tierPercentage);
}
// sorting to ensure smallest to largest values in order always
tierPercentages.sort(function (a, b) {
return a - b;
});
ticksY = {
display: false,
min: tierPercentages[0],
max: tierPercentages[tierPercentages.length - 1] // get the last (biggest) in array
};
}