Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

Fixed double error message shown for site title when it's too long

Browse source 
no issue

- removed the duplicated `<GhErrorMessage>` that is shown when the site title is too long
- removed confusing double `class` attribute on general settings form field, browsers were only respecting the latter class attribute
This commit is contained in:
Kevin Ansfield 2021-10-14 11:39:07 +01:00
parent 869cc9d47a
commit a6a9ecad22
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ghost/admin/app/components/settings/design/general-settings-form.hbs
View file

@ -6,11 +6,8 @@
{{#each uploader.errors as |error|}} {{#each uploader.errors as |error|}}
<div class="gh-setting-error" data-test-error="icon">{{or error.context error.message}}</div> <div class="gh-setting-error" data-test-error="icon">{{or error.context error.message}}</div>
{{/each}} {{/each}}
<div class="w-100 flex flex-column flex-row-ns">
<GhErrorMessage @errors={{settings.errors}} @property="description" class="w-100 red"/>
</div>
<div class="gh-setting-action" class="flex flex-column" data-test-setting="description"> <div class="gh-setting-action" data-test-setting="description">
<GhFormGroup @errors={{this.settings.errors}} @hasValidated={{this.settings.hasValidated}} @property="description" @class="description-container-labs"> <GhFormGroup @errors={{this.settings.errors}} @hasValidated={{this.settings.hasValidated}} @property="description" @class="description-container-labs">
<GhTextInput <GhTextInput
@value={{readonly this.settings.description}} @value={{readonly this.settings.description}}