mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-02-17 23:44:39 -05:00
Resolved template linting errors in <Settings::MembersEmailLabs>
refs https://github.com/TryGhost/Team/issues/1441 - applying scout rule - brings template closer to swapping backing class to glimmer
This commit is contained in:
Kevin Ansfield
parent
c76526b4ac
commit
a4ca693871
2 changed files with 57 additions and 24 deletions
|
|
@ -1262,3 +1262,18 @@ add|ember-template-lint|no-action|228|83|228|83|259aa927a526d3449245a05298d5cb8b
|
|||
add|ember-template-lint|no-action|229|123|229|123|259aa927a526d3449245a05298d5cb8b1961de4e|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
add|ember-template-lint|no-passed-in-event-handlers|192|48|192|48|a302b99c2a5682fd9186a16dce373578fe74a18b|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
add|ember-template-lint|no-passed-in-event-handlers|207|40|207|40|7ca43fc52964fe52050eacf376e788422c34cf7a|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-action|10|86|10|86|fd1f2c0329cecb082e8b5c31e2b08ea9ba3f00f0|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-action|11|117|11|117|fd1f2c0329cecb082e8b5c31e2b08ea9ba3f00f0|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-action|120|57|120|57|525caa6410c5001714d3891b1e99cc7c6b9aa6d2|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-action|137|60|137|60|9ba0927837b1ab440136aff1d92f0b694752dea8|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-action|138|57|138|57|3c80294f3c8009bf5e59ff31d44e18cbc4c0ab89|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-action|147|56|147|56|9ba0927837b1ab440136aff1d92f0b694752dea8|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-action|148|53|148|53|3c80294f3c8009bf5e59ff31d44e18cbc4c0ab89|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-action|163|61|163|61|fff7691202120582f36d72eb959fc385580797bb|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-action|178|62|178|62|6315ee6c3906523f2605a9c48abce941fc345092|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-action|192|55|192|55|552676ca594b7e31314643aed74b61cf1746ed05|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-action|207|47|207|47|bdabf075c725d81a440009b6fe8d5c9f4dce1b24|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-action|228|83|228|83|259aa927a526d3449245a05298d5cb8b1961de4e|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-action|229|123|229|123|259aa927a526d3449245a05298d5cb8b1961de4e|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-passed-in-event-handlers|192|48|192|48|a302b99c2a5682fd9186a16dce373578fe74a18b|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
remove|ember-template-lint|no-passed-in-event-handlers|207|40|207|40|7ca43fc52964fe52050eacf376e788422c34cf7a|1648684800000|1651276800000|1653868800000|app/components/settings/members-email-labs.hbs
|
||||
|
|
|
|||
|
|
@ -7,8 +7,15 @@
|
|||
<p class="gh-expandable-description">Newsletter features are active, posts can be sent by email</p>
|
||||
</div>
|
||||
<div class="for-switch">
|
||||
<label class="switch" for="email-newsletter-enabled" {{on "click" (action "toggleEmailNewsletterEnabled")}}>
|
||||
<input type="checkbox" checked={{this.emailNewsletterEnabled}} class="gh-input" {{on "click" (action "toggleEmailNewsletterEnabled")}} name="email-newsletter-enabled" data-test-checkbox="email-newsletter-enabled">
|
||||
<label class="switch">
|
||||
<input
|
||||
type="checkbox"
|
||||
checked={{this.emailNewsletterEnabled}}
|
||||
class="gh-input"
|
||||
{{on "change" this.toggleEmailNewsletterEnabled}}
|
||||
name="email-newsletter-enabled"
|
||||
data-test-checkbox="email-newsletter-enabled"
|
||||
>
|
||||
<span class="input-toggle-component mt1"></span>
|
||||
</label>
|
||||
</div>
|
||||
|
|
@ -117,7 +124,7 @@
|
|||
<h4 class="gh-expandable-title">Default newsletter recipients</h4>
|
||||
<p class="gh-expandable-description">When you publish new content, who do you usually want to send it to?</p>
|
||||
</div>
|
||||
<button type="button" class="gh-btn" {{action (toggle "defaultRecipientsOpen" this)}} data-test-toggle-membersemail>
|
||||
<button type="button" class="gh-btn" {{on "click" (toggle-action "defaultRecipientsOpen" this)}} data-test-toggle-membersemail>
|
||||
<span>{{if this.defaultRecipientsOpen "Close" "Expand"}}</span>
|
||||
</button>
|
||||
</div>
|
||||
|
|
@ -134,8 +141,8 @@
|
|||
<Settings::MembersEmail::DefaultRecipientsSelect
|
||||
@recipients={{this.recipientsSelectValue}}
|
||||
@segment={{this.settings.editorDefaultEmailRecipientsFilter}}
|
||||
@onRecipientsChange={{action "setDefaultEmailRecipients"}}
|
||||
@onSegmentChange={{action "setDefaultEmailRecipientsFilter"}}
|
||||
@onRecipientsChange={{this.setDefaultEmailRecipients}}
|
||||
@onSegmentChange={{this.setDefaultEmailRecipientsFilter}}
|
||||
/>
|
||||
</div>
|
||||
</div>
|
||||
|
|
@ -144,8 +151,8 @@
|
|||
<Settings::MembersEmail::DefaultRecipientsSelect
|
||||
@recipients={{this.recipientsSelectValue}}
|
||||
@segment={{this.settings.editorDefaultEmailRecipientsFilter}}
|
||||
@onRecipientsChange={{action "setDefaultEmailRecipients"}}
|
||||
@onSegmentChange={{action "setDefaultEmailRecipientsFilter"}}
|
||||
@onRecipientsChange={{this.setDefaultEmailRecipients}}
|
||||
@onSegmentChange={{this.setDefaultEmailRecipientsFilter}}
|
||||
/>
|
||||
</div>
|
||||
{{/if}}
|
||||
|
|
@ -160,7 +167,7 @@
|
|||
<h4 class="gh-expandable-title">Mailgun configuration</h4>
|
||||
<p class="gh-expandable-description">The Mailgun API is used for bulk email newsletter delivery. <a href="https://ghost.org/docs/faq/mailgun-newsletters/" target="_blank" rel="noopener noreferrer">Why is this required?</a></p>
|
||||
</div>
|
||||
<button type="button" class="gh-btn" {{action (toggle "membersEmailOpen" this)}} data-test-toggle-membersemail>
|
||||
<button type="button" class="gh-btn" {{on "click" (toggle-action "membersEmailOpen" this)}} data-test-toggle-membersemail>
|
||||
<span>{{if this.membersEmailOpen "Close" "Expand"}}</span>
|
||||
</button>
|
||||
</div>
|
||||
|
|
@ -175,7 +182,7 @@
|
|||
<PowerSelect
|
||||
@options={{this.mailgunRegions}}
|
||||
@selected={{this.mailgunRegion}}
|
||||
@onChange={{action "setMailgunRegion"}}
|
||||
@onChange={{this.setMailgunRegion}}
|
||||
@class="gh-select"
|
||||
@searchEnabled={{false}}
|
||||
@triggerComponent="gh-power-select/trigger"
|
||||
|
|
@ -186,12 +193,14 @@
|
|||
</div>
|
||||
</GhFormGroup>
|
||||
<GhFormGroup @class="no-margin">
|
||||
<label class="fw6 f8">Mailgun domain</label>
|
||||
<GhTextInput
|
||||
@value={{readonly this.mailgunSettings.domain}}
|
||||
@input={{action "setMailgunDomain"}}
|
||||
@class="mt1"
|
||||
data-test-mailgun-domain-input={{true}}
|
||||
<label class="fw6 f8" for="mailgun-domain">Mailgun domain</label>
|
||||
<input
|
||||
id="mailgun-domain"
|
||||
type="text"
|
||||
class="gh-input mt1"
|
||||
value={{this.mailgunSettings.domain}}
|
||||
{{on "input" this.setMailgunDomain}}
|
||||
data-test-mailgun-domain-input
|
||||
/>
|
||||
</GhFormGroup>
|
||||
</div>
|
||||
|
|
@ -200,13 +209,15 @@
|
|||
</p>
|
||||
</GhFormGroup>
|
||||
<GhFormGroup>
|
||||
<label class="fw6 f8">Mailgun Private API key</label>
|
||||
<GhTextInput
|
||||
@type="password"
|
||||
@value={{readonly this.mailgunSettings.apiKey}}
|
||||
@input={{action "setMailgunApiKey"}}
|
||||
@class="mt1 password" @autocomplete="new-password"
|
||||
data-test-mailgun-api-key-input={{true}}
|
||||
<label class="fw6 f8" for="mailgun-private-api">Mailgun Private API key</label>
|
||||
<input
|
||||
id="mailgun-private-api"
|
||||
type="password"
|
||||
value={{this.mailgunSettings.apiKey}}
|
||||
{{on "input" this.setMailgunApiKey}}
|
||||
class="gh-input mt1 password"
|
||||
autocomplete="new-password"
|
||||
data-test-mailgun-api-key-input
|
||||
/>
|
||||
<p>Find your Mailgun API keys
|
||||
<a href="https://app.mailgun.com/app/account/security/api_keys" target="_blank" class="fw5" rel="noopener noreferrer">here</a>
|
||||
|
|
@ -225,8 +236,15 @@
|
|||
<p class="gh-expandable-description">Track how many members are reading your emails</p>
|
||||
</div>
|
||||
<div class="for-switch">
|
||||
<label class="switch" for="email-track-opens" {{on "click" (action "toggleEmailTrackOpens")}}>
|
||||
<input type="checkbox" checked={{this.settings.emailTrackOpens}} class="gh-input" {{on "click" (action "toggleEmailTrackOpens")}} name="email-track-opens" data-test-checkbox="email-track-opens">
|
||||
<label class="switch">
|
||||
<input
|
||||
id="email-track-opens"
|
||||
type="checkbox"
|
||||
checked={{this.settings.emailTrackOpens}}
|
||||
class="gh-input"
|
||||
{{on "change" this.toggleEmailTrackOpens}}
|
||||
data-test-checkbox="email-track-opens"
|
||||
>
|
||||
<span class="input-toggle-component mt1"></span>
|
||||
</label>
|
||||
</div>
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue