From a441825c3f1fa85ac59a3f5c164bc5c4a0435d61 Mon Sep 17 00:00:00 2001 From: Fabien O'Carroll Date: Wed, 13 Oct 2021 11:09:50 +0200 Subject: [PATCH] Passed MembersAPI the OffersAPI over OfferRepository no-issue The MembersAPI using the OfferRepository coupled it to the internals of the Offers Module - instead we pass the "external" API - so that we can change the internals, and not have to update the MembersAPI's usage. --- core/server/services/members/api.js | 2 +- core/server/services/offers/service.js | 1 - package.json | 2 +- yarn.lock | 8 ++++---- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/core/server/services/members/api.js b/core/server/services/members/api.js index e5f88107b0..c94ba8f5f2 100644 --- a/core/server/services/members/api.js +++ b/core/server/services/members/api.js @@ -187,7 +187,7 @@ function createApiInstance(config) { }, stripeAPIService: stripeService.api, logger: logging, - offerRepository: offersService.repository, + offersAPI: offersService.api, labsService: labsService }); diff --git a/core/server/services/offers/service.js b/core/server/services/offers/service.js index 9e02027632..a53cb0c9c8 100644 --- a/core/server/services/offers/service.js +++ b/core/server/services/offers/service.js @@ -26,7 +26,6 @@ module.exports = { }); this.api = offersModule.api; - this.repository = offersModule.repository; let initCalled = false; if (labs.isSet('offers')) { diff --git a/package.json b/package.json index 38c52724bd..b2b1200ab2 100644 --- a/package.json +++ b/package.json @@ -79,7 +79,7 @@ "@tryghost/limit-service": "0.6.4", "@tryghost/logging": "0.1.7", "@tryghost/magic-link": "1.0.13", - "@tryghost/members-api": "2.1.1", + "@tryghost/members-api": "2.2.0", "@tryghost/members-csv": "1.1.7", "@tryghost/members-importer": "0.3.3", "@tryghost/members-offers": "0.6.0", diff --git a/yarn.lock b/yarn.lock index 5617d534d2..531b2e55e5 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1488,10 +1488,10 @@ "@tryghost/domain-events" "^0.1.2" "@tryghost/member-events" "^0.2.1" -"@tryghost/members-api@2.1.1": - version "2.1.1" - resolved "https://registry.yarnpkg.com/@tryghost/members-api/-/members-api-2.1.1.tgz#e4ef101fb7536f96f631b09d339e2e5735c01001" - integrity sha512-iLPfYQkzRQxWKoBWuYt2ytEn1RVKJFVtoQUBMwizyJgREU7qFkhoK00jXpc3plQXyhojIEVNJChE9VWG229kiA== +"@tryghost/members-api@2.2.0": + version "2.2.0" + resolved "https://registry.yarnpkg.com/@tryghost/members-api/-/members-api-2.2.0.tgz#58fdad00b42997222fac7a23c601f63bfca75e13" + integrity sha512-gkGvKzCFUHFxcBs/XXDwpkhE1+DQOJlB5CoIBtQEc/NMi/T4kZW+K2SeHxxkHmpUAediFTJFqgF1WDh2THfogw== dependencies: "@tryghost/debug" "^0.1.2" "@tryghost/errors" "^0.2.9"