Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

🎨 Return gscan warnings from theme API (#7367)

Browse source 
- return warnings from gscan so we can let users know about potential issues
This commit is contained in:
Hannah Wolfe 2016-09-14 18:49:41 +01:00 committed by Kevin Ansfield
parent de66a61f59
commit a40ff3b276
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
core/server/api/themes.js
View file

@ -84,7 +84,11 @@ themes = {
}) })
.then(function (settings) { .then(function (settings) {
// gscan theme structure !== ghost theme structure // gscan theme structure !== ghost theme structure
return {themes: [_.find(settings.availableThemes.value, {name: zip.shortName})]}; var themeObject = _.find(settings.availableThemes.value, {name: zip.shortName}) || {};
if (theme.results.warning.length > 0) {
themeObject.warnings = _.cloneDeep(theme.results.warning);
}
return {themes: [themeObject]};
}) })
.finally(function () { .finally(function () {
// remove zip upload from multer // remove zip upload from multer

2
package.json
View file

@ -46,7 +46,7 @@
"fs-extra": "0.30.0", "fs-extra": "0.30.0",
"ghost-gql": "0.0.5", "ghost-gql": "0.0.5",
"glob": "5.0.15", "glob": "5.0.15",
"gscan": "0.0.13", "gscan": "0.0.14",
"html-to-text": "2.1.3", "html-to-text": "2.1.3",
"image-size": "0.5.0", "image-size": "0.5.0",
"intl": "1.2.4", "intl": "1.2.4",