Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Updated 'Users' to 'Staff' in search dropdown component (#20064)

Browse source 
No ref

- This copy change allows us to use consistent copy in both the general
search as well as the internal linking search component in the editor.
This commit is contained in:
Sanne de Vries 2024-04-22 16:49:43 +02:00 • committed by GitHub
parent 3771b2fca4
commit a2bbe6b3c3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/components/gh-search-input.js
View file

@ -25,7 +25,7 @@ export default class GhSearchInputComponent extends Component {
this.router.transitionTo('lexical-editor.edit', 'page', id); this.router.transitionTo('lexical-editor.edit', 'page', id);
} }
if (selected.groupName === 'Users') { if (selected.groupName === 'Staff') {
let id = selected.id.replace('user.', ''); let id = selected.id.replace('user.', '');
this.router.transitionTo('settings-x.settings-x', `staff/${id}`); this.router.transitionTo('settings-x.settings-x', `staff/${id}`);
} }

2
ghost/admin/app/services/search.js
View file

@ -30,7 +30,7 @@ export default class SearchService extends Service {
titleField: 'title' titleField: 'title'
}, },
{ {
name: 'Users', name: 'Staff',
model: 'user', model: 'user',
fields: ['id', 'slug', 'url', 'name'], // id not used but required for API to have correct url fields: ['id', 'slug', 'url', 'name'], // id not used but required for API to have correct url
idField: 'slug', idField: 'slug',

4
ghost/admin/tests/acceptance/search-test.js
View file

@ -65,7 +65,7 @@ describe('Acceptance: Search', function () {
expect(find('[data-test-modal="search"]'), 'search modal').to.not.exist; expect(find('[data-test-modal="search"]'), 'search modal').to.not.exist;
}); });
it('finds posts, pages, users, and tags when typing', async function () { it('finds posts, pages, staff, and tags when typing', async function () {
await visit('/dashboard'); await visit('/dashboard');
await click('[data-test-button="search"]'); await click('[data-test-button="search"]');
await typeInSearch('first'); // search is not case sensitive await typeInSearch('first'); // search is not case sensitive
@ -73,7 +73,7 @@ describe('Acceptance: Search', function () {
// all groups are present // all groups are present
const groupNames = findAll('.ember-power-select-group-name'); const groupNames = findAll('.ember-power-select-group-name');
expect(groupNames, 'group names').to.have.length(4); expect(groupNames, 'group names').to.have.length(4);
expect(groupNames.map(el => el.textContent.trim())).to.deep.equal(['Posts', 'Pages', 'Users', 'Tags']); expect(groupNames.map(el => el.textContent.trim())).to.deep.equal(['Posts', 'Pages', 'Staff', 'Tags']);
// correct results are found // correct results are found
const options = findAll('.ember-power-select-option'); const options = findAll('.ember-power-select-option');