Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-17 23:44:39 -05:00
Code Issues Activity

Updated newsletter recipientFilter to use slugs instead of instead

Browse source 
refs https://github.com/TryGhost/Team/issues/1576
refs https://ghost.slack.com/archives/C02G9E68C/p1651763933403669?thread_ts=1651763878.116549&cid=C02G9E68C
This commit is contained in:
Simon Backx 2022-05-05 17:37:34 +02:00
parent 1f5f9645e6
commit a103184c6a
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/models/newsletter.js
View file

@ -38,7 +38,7 @@ export default class Newsletter extends Model.extend(ValidationEngine) {
* The filter that we should use to filter out members that are subscribed to this newsletter
*/
get recipientFilter() {
const idFilter = 'newsletters.id:' + this.id;
const idFilter = 'newsletters.slug:' + this.slug;
if (this.visibility === 'paid') {
return idFilter + '+status:-free';
}

3
ghost/admin/tests/acceptance/editor-test.js
View file

@ -878,8 +878,7 @@ describe('Acceptance: Editor', function () {
// Enable stripe to also show paid members breakdown
enableStripe(this.server);
// Note: we need to set the ID of a newsletter to some string value because of how NQL filters work.
const newsletter = this.server.create('newsletter', {status: 'active', name: 'test newsletter', id: 'test-newsletter'});
const newsletter = this.server.create('newsletter', {status: 'active', name: 'test newsletter', slug: 'test-newsletter'});
this.server.createList('member', 4, {status: 'free', newsletters: [newsletter]});
this.server.createList('member', 2, {status: 'paid', newsletters: [newsletter]});