Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity

🐛 Fixed search failing for posts without excerpt

Browse source 
- the excerpt was `null` in some cases when post didn't have any excerpt, causing search to fail
This commit is contained in:
Rishabh 2022-07-19 11:37:20 +05:30
parent a1fab8c7f7
commit 9fc0cd7e29
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ghost/sodo-search/src/components/PopupModal.js
View file

@ -259,7 +259,7 @@ function getMatchIndexes({text, highlight}) {
} }
}); });
const matchRegex = new RegExp(`${highlightRegexText}`, 'ig'); const matchRegex = new RegExp(`${highlightRegexText}`, 'ig');
let matches = text.matchAll(matchRegex); let matches = text?.matchAll(matchRegex);
const indexes = []; const indexes = [];
for (const match of matches) { for (const match of matches) {
indexes.push({ indexes.push({
@ -307,6 +307,8 @@ function getHighlightParts({text, highlight}) {
} }
function HighlightedSection({text = '', highlight = '', isExcerpt}) { function HighlightedSection({text = '', highlight = '', isExcerpt}) {
text = text || '';
highlight = highlight || '';
let {parts, highlightIndexes} = getHighlightParts({text, highlight}); let {parts, highlightIndexes} = getHighlightParts({text, highlight});
if (isExcerpt && highlightIndexes?.[0]) { if (isExcerpt && highlightIndexes?.[0]) {
const startIdx = highlightIndexes?.[0]?.startIdx; const startIdx = highlightIndexes?.[0]?.startIdx;