From 9e9c78728296c04180418e2c7688944d5deff657 Mon Sep 17 00:00:00 2001 From: Paul Adam Davis Date: Sun, 21 Sep 2014 20:35:33 +0100 Subject: [PATCH] Fix minor IE UI issues Closes #4088 - Fix Flexbox issue with the user list - Fix positioning issue with the mobile menu toggle icon - Make the mobile settings nav use absolute positioning (as fixed elements don't move inside a `transform: translate(...);` parent --- core/client/assets/sass/layouts/about.scss | 2 ++ core/client/assets/sass/layouts/default.scss | 7 ++++++- core/client/assets/sass/layouts/settings.scss | 6 +++--- core/client/assets/sass/layouts/users.scss | 8 ++++---- 4 files changed, 15 insertions(+), 8 deletions(-) diff --git a/core/client/assets/sass/layouts/about.scss b/core/client/assets/sass/layouts/about.scss index dbc92ad192..54a91dcc51 100644 --- a/core/client/assets/sass/layouts/about.scss +++ b/core/client/assets/sass/layouts/about.scss @@ -38,6 +38,7 @@ h1 { margin-top: -6px; margin-bottom: -21px; + font-feature-settings: normal; .version { font-weight: 300; @@ -71,6 +72,7 @@ float: left; display: inline-block; margin: 0; + font-feature-settings: normal; } dt { margin-right: 5px; diff --git a/core/client/assets/sass/layouts/default.scss b/core/client/assets/sass/layouts/default.scss index 9809e6d986..609a5207d4 100644 --- a/core/client/assets/sass/layouts/default.scss +++ b/core/client/assets/sass/layouts/default.scss @@ -135,7 +135,12 @@ // The burger to expand .global-nav menu .menu-button { - @include icon($i-menu, 18px) { line-height: 44px; } + @include icon($i-menu, 18px) { + position: absolute; + top: 50%; + left: 22px; + transform: translateY(-50%); + } display: block; position: absolute; top: 0; diff --git a/core/client/assets/sass/layouts/settings.scss b/core/client/assets/sass/layouts/settings.scss index dbd781f244..8bdba14b69 100644 --- a/core/client/assets/sass/layouts/settings.scss +++ b/core/client/assets/sass/layouts/settings.scss @@ -12,8 +12,8 @@ // Main settings-menu styles, apply to every item .settings-menu { width: 25%; - position: fixed; - top: 60px; + position: absolute; + top: 0; left: 0; bottom: 0; z-index: 700; @@ -24,7 +24,7 @@ } @media (max-width: 900px) { - top: 44px; + top: 0; } ul { diff --git a/core/client/assets/sass/layouts/users.scss b/core/client/assets/sass/layouts/users.scss index a732c259ff..3e4cc85067 100644 --- a/core/client/assets/sass/layouts/users.scss +++ b/core/client/assets/sass/layouts/users.scss @@ -19,21 +19,21 @@ .object-list-item { - @media (max-width: 500px) { + @media (max-width: 600px) { display: block; padding: 15px 0; @include clearfix; } - @media (min-width: 501px) { + @media (min-width: 601px) { display: flex; justify-content: start; align-items: center; padding: 0 15px; + height: 68px; } border-top: 1px solid $lightbrown; - min-height: 68px; } // .object-list-item @@ -89,7 +89,7 @@ a.object-list-item { .object-list-item-body { - flex: 1; + flex: 1 1 auto; align-items: stretch; padding-left: 15px;