Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Fixed body style dropdown overflow issue

Browse source 
no issue

When opening the 'body style' dropdown in the newsletter settings, the dropdown was not completely visible. The next 'liquid' tab covered the dropdown. This makes some adjustments to the overflow of the liquid containers and z-index of the buttons and containers to fix that.

It also removes overflow-y: auto from one of the containers because it cropped the shadow if the dropdown, while that container could never scroll (parent is scrollable).
This commit is contained in:
Simon Backx 2023-03-17 11:58:27 +01:00
parent 3302f4125e
commit 9bdffdf89d
4 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/components/modals/newsletters/edit/design-labs.hbs
View file

@ -116,7 +116,7 @@
{{svg-jar "email-body"}} Body
<span class="gh-nav-button-expand">{{svg-jar (if isOpen "arrow-up-stroke" "arrow-down-stroke")}}</span>
</button>
{{#liquid-if isOpen}}
{{#liquid-if isOpen class="show-overflow"}}
<div class="modal-fullsettings-tab-expanded">
<div class="gh-stack">
<GhFormGroup class="gh-stack-item row">

2
ghost/admin/app/components/modals/newsletters/edit/design.hbs
View file

@ -116,7 +116,7 @@
{{svg-jar "email-body"}} Body
<span class="gh-nav-button-expand">{{svg-jar (if isOpen "arrow-up-stroke" "arrow-down-stroke")}}</span>
</button>
{{#liquid-if isOpen}}
{{#liquid-if isOpen class="show-overflow"}}
<div class="modal-fullsettings-tab-expanded">
<div class="gh-stack">
<GhFormGroup class="gh-stack-item row">

4
ghost/admin/app/styles/components/modals.css
View file

@ -629,7 +629,6 @@
flex-direction: column;
justify-content: space-between;
flex-grow: 1;
overflow-y: auto;
padding: 0;
margin-bottom: 24px;
}
@ -655,6 +654,7 @@
font-weight: 400;
font-size: 1.45rem;
transition: none;
z-index: 0;
}
.modal-fullsettings-tab:hover {
@ -790,4 +790,4 @@
.modal-reauthenticate .gh-signin .gh-btn-login {
margin-top: 32px;
}
}

1
ghost/admin/app/styles/patterns/global.css
View file

@ -776,6 +776,7 @@ input[type="image"] {
.liquid-container.show-overflow,
.liquid-container.show-overflow .liquid-child {
overflow: visible;
z-index: 1;
}
.liquid-container.show-overflow.liquid-animating,
.liquid-container.show-overflow.liquid-animating .liquid-child {