From 9b347d6d951245b40511c977691e64b98341cd1e Mon Sep 17 00:00:00 2001
From: Naz Gargol <nazargargol@gmail.com>
Date: Tue, 29 Oct 2019 13:16:47 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fixed=203.0=20migration=20on=20S?=
 =?UTF-8?q?QLite=20with=20many=20posts=20(#11302)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

refs https://github.com/TryGhost/Ghost/pull/11270

- Fixed 3.0/11-update-posts-html migration which failed in scenario when more than 999 posts with posts_meta relation were present
- The issue was originally spotted here: https://github.com/TryGhost/Ghost/pull/11270#issuecomment-546248308
- The main problem is in the `SELECT` statement which is generated for `findAll` method in Bookshelf which creates `WHERE IN(post_ids_here)` statement with all posts in the database
- Using knex directly as that's a preferred way to write migrations (does not depend on the model layer)
---
 .../versions/3.0/11-update-posts-html.js      | 43 +++++++++++++++----
 1 file changed, 35 insertions(+), 8 deletions(-)

diff --git a/core/server/data/migrations/versions/3.0/11-update-posts-html.js b/core/server/data/migrations/versions/3.0/11-update-posts-html.js
index c183a40787..92eeaa4036 100644
--- a/core/server/data/migrations/versions/3.0/11-update-posts-html.js
+++ b/core/server/data/migrations/versions/3.0/11-update-posts-html.js
@@ -1,7 +1,7 @@
 const _ = require('lodash');
 const Promise = require('bluebird');
+const htmlToText = require('html-to-text');
 const common = require('../../../../lib/common');
-const models = require('../../../../models');
 const converters = require('../../../../lib/mobiledoc/converters');
 
 module.exports.config = {
@@ -9,7 +9,7 @@ module.exports.config = {
 };
 
 module.exports.up = (options) => {
-    const postAllColumns = ['id', 'html', 'mobiledoc'];
+    const columns = ['id', 'html', 'mobiledoc', 'plaintext'];
 
     let localOptions = _.merge({
         context: {internal: true},
@@ -17,14 +17,15 @@ module.exports.up = (options) => {
     }, options);
 
     common.logging.info('Starting re-generation of posts html.');
-
-    return models.Post.findAll(_.merge({columns: postAllColumns}, localOptions))
-        .then(function (posts) {
-            return Promise.map(posts.models, function (post) {
+    return localOptions
+        .transacting('posts')
+        .select(columns)
+        .then((posts) => {
+            return Promise.map(posts, function (post) {
                 let mobiledoc;
 
                 try {
-                    mobiledoc = JSON.parse(post.get('mobiledoc') || null);
+                    mobiledoc = JSON.parse(post.mobiledoc || null);
 
                     if (!mobiledoc) {
                         common.logging.warn(`No mobiledoc for ${post.id}. Skipping.`);
@@ -37,7 +38,33 @@ module.exports.up = (options) => {
 
                 const html = converters.mobiledocConverter.render(mobiledoc);
 
-                return models.Post.edit({html}, _.merge({id: post.id}, localOptions));
+                const updatedAttrs = {
+                    html: html
+                };
+
+                // NOTE: block comes straight from the Post model (https://github.com/TryGhost/Ghost/blob/3.0.0/core/server/models/post.js#L416)
+                if (html !== post.html || !post.plaintext) {
+                    const plaintext = htmlToText.fromString(post.html, {
+                        wordwrap: 80,
+                        ignoreImage: true,
+                        hideLinkHrefIfSameAsText: true,
+                        preserveNewlines: true,
+                        returnDomByDefault: true,
+                        uppercaseHeadings: false
+                    });
+
+                    // CASE: html is e.g. <p></p>
+                    // @NOTE: Otherwise we will always update the resource to `plaintext: ''` and Bookshelf thinks that this
+                    //        value was modified.
+                    if (plaintext || plaintext !== post.plaintext) {
+                        updatedAttrs.plaintext = plaintext;
+                    }
+                }
+
+                return localOptions
+                    .transacting('posts')
+                    .where('id', '=', post.id)
+                    .update(updatedAttrs);
             }, {concurrency: 100});
         })
         .then(() => {