Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Fixed small UI bugs from the AdminX design system migration (#18991)

Browse source 
no issue

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at a19dd1f</samp>

Refactored the email settings UI for default recipients by reusing and
adapting the Twitter settings UI. Removed an unnecessary prop from the
`ImageUpload` component.
This commit is contained in:
Jono M 2023-11-15 11:57:55 +00:00 • committed by GitHub
parent 4651ef3d9b
commit 99765206c1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
apps/admin-x-settings/src/components/settings/email/DefaultRecipients.tsx
View file

@ -142,7 +142,6 @@ const DefaultRecipients: React.FC<{ keywords: string[] }> = ({keywords}) => {
title='Filter' title='Filter'
values={selectedSegments} values={selectedSegments}
async async
clearBg
defaultOptions defaultOptions
onChange={updateSelectedSegments} onChange={updateSelectedSegments}
/> />

4
apps/admin-x-settings/src/components/settings/general/Twitter.tsx
View file

@ -2,7 +2,7 @@ import React from 'react';
import TopLevelGroup from '../../TopLevelGroup'; import TopLevelGroup from '../../TopLevelGroup';
import usePinturaEditor from '../../../hooks/usePinturaEditor'; import usePinturaEditor from '../../../hooks/usePinturaEditor';
import useSettingGroup from '../../../hooks/useSettingGroup'; import useSettingGroup from '../../../hooks/useSettingGroup';
import {ImageUpload, SettingGroupContent, TextField, TwitterLogo, withErrorBoundary} from '@tryghost/admin-x-design-system'; import {ImageUpload, SettingGroupContent, TextField, XLogo, withErrorBoundary} from '@tryghost/admin-x-design-system';
import {getImageUrl, useUploadImage} from '@tryghost/admin-x-framework/api/images'; import {getImageUrl, useUploadImage} from '@tryghost/admin-x-framework/api/images';
import {getSettingValues} from '@tryghost/admin-x-framework/api/settings'; import {getSettingValues} from '@tryghost/admin-x-framework/api/settings';
import {useHandleError} from '@tryghost/admin-x-framework/hooks'; import {useHandleError} from '@tryghost/admin-x-framework/hooks';
@ -56,7 +56,7 @@ const Twitter: React.FC<{ keywords: string[] }> = ({keywords}) => {
const inputFields = ( const inputFields = (
<div className="flex flex-col gap-3 md:flex-row"> <div className="flex flex-col gap-3 md:flex-row">
<div className="pt-1"> <div className="pt-1">
<TwitterLogo className='-mb-1 h-10 w-10' /> <XLogo className='-mb-1 h-10 w-10' />
</div> </div>
<div className="w-full md:mr-[52px]"> <div className="w-full md:mr-[52px]">
<div className="mb-2"> <div className="mb-2">