From 991b6e92a37bb5acf4e5f8bb95a5fecfd332312b Mon Sep 17 00:00:00 2001
From: Fabien 'egg' O'Carroll <fabien@allou.is>
Date: Thu, 11 Feb 2021 17:43:36 +0000
Subject: [PATCH] Ensured latest subscription data is always stored (#240)

no-issue

If we receive webhooks out of order, e.g. a
`customer.subscription.updated` with a status of 'active', followed by a
`customer.subscription.created` with a status of 'incomplete'. We would
overwrite the correct value with data from the "older" webhook. This
ensures that we always fetch the latest data from the Stripe API before
storing in the database.
---
 ghost/members-api/lib/repositories/member/index.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ghost/members-api/lib/repositories/member/index.js b/ghost/members-api/lib/repositories/member/index.js
index 17c7f001db..168f26a9c9 100644
--- a/ghost/members-api/lib/repositories/member/index.js
+++ b/ghost/members-api/lib/repositories/member/index.js
@@ -169,7 +169,7 @@ module.exports = class MemberRepository {
             throw new Error('Subscription is not associated with a customer for the member');
         }
 
-        const subscription = data.subscription;
+        const subscription = await this._stripeAPIService.getSubscription(data.subscription.id);
         let paymentMethodId;
         if (!subscription.default_payment_method) {
             paymentMethodId = null;