Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-15 03:01:37 -05:00
Code Issues Activity

Fixed email header divider showing when title+icon are disabled but no publication icon is set

Browse source 
refs https://github.com/TryGhost/Team/issues/755

- the default value for `show_header_icon` is `true` but if there's no publication icon set then it should be read as `false` when rendering the email
This commit is contained in:
Kevin Ansfield 2021-06-08 10:18:10 +01:00
parent 7069cc1221
commit 97fec8443b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/server/services/mega/post-email-serializer.js
View file

@ -136,7 +136,7 @@ const getTemplateSettings = async () => {
const getLabsTemplateSettings = async () => {
const templateSettings = {
headerImage: settingsCache.get('newsletter_header_image'),
showHeaderIcon: settingsCache.get('newsletter_show_header_icon'),
showHeaderIcon: settingsCache.get('newsletter_show_header_icon') && settingsCache.get('icon'),
showHeaderTitle: settingsCache.get('newsletter_show_header_title'),
showFeatureImage: settingsCache.get('newsletter_show_feature_image'),
titleFontCategory: settingsCache.get('newsletter_title_font_category'),