From 97ca3db8b157384b586f0b3f59bba18d935c2636 Mon Sep 17 00:00:00 2001
From: Djordje Vlaisavljevic <dzvlais@gmail.com>
Date: Mon, 21 Feb 2022 17:30:03 +0100
Subject: [PATCH] Fixed linting issues

refs https://github.com/TryGhost/Team/issues/1096
---
 ghost/admin/.lint-todo                        |  2 ++
 .../admin/app/components/gh-portal-links.hbs  | 30 +++++++++----------
 2 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/ghost/admin/.lint-todo b/ghost/admin/.lint-todo
index 86eae7d025..7c276cc23e 100644
--- a/ghost/admin/.lint-todo
+++ b/ghost/admin/.lint-todo
@@ -1837,3 +1837,5 @@ remove|ember-template-lint|no-duplicate-attributes|9|4|9|4|6b5f76f812df2b84f2ed9
 add|ember-template-lint|no-duplicate-landmark-elements|131|24|131|24|9eb7d301f1f50334e793aafab8f6b9e8905125ab|1645142400000|1647734400000|1650322800000|app/components/modal-product.hbs
 add|ember-template-lint|no-nested-landmark|131|24|131|24|9eb7d301f1f50334e793aafab8f6b9e8905125ab|1645142400000|1647734400000|1650322800000|app/components/modal-product.hbs
 remove|ember-template-lint|table-groups|5|8|5|8|9b53737f259340d2970119c70be1af3a83081cab|1643760000000|1646352000000|1648940400000|app/components/gh-portal-links.hbs
+remove|ember-template-lint|no-action|11|72|11|72|a8b13fedc345ad6ca2c1514b209e84a19d82915d|1643760000000|1646352000000|1648940400000|app/components/gh-portal-links.hbs
+remove|ember-template-lint|no-invalid-interactive|11|64|11|64|5b5bb32075e5f0470fbe12d099229964f1dc7dfe|1643760000000|1646352000000|1648940400000|app/components/gh-portal-links.hbs
diff --git a/ghost/admin/app/components/gh-portal-links.hbs b/ghost/admin/app/components/gh-portal-links.hbs
index 0269ce706d..82faf8b90f 100644
--- a/ghost/admin/app/components/gh-portal-links.hbs
+++ b/ghost/admin/app/components/gh-portal-links.hbs
@@ -10,7 +10,7 @@
                     <td>
                         <div class='toggle-header'>
                             <h4>{{this.sectionHeaderLabel}}</h4>
-                            <h4 class='gh-portal-links-cell toggle' onclick={{action "toggleShowLinks"}}>{{this.toggleValue}}</h4>
+                            <h4 role="button" class='gh-portal-links-cell toggle' {{on "click" this.toggleShowLinks}}>{{this.toggleValue}}</h4>
                         </div>
                     </td>
                 </tr>
@@ -344,7 +344,7 @@
                     <td>
                         <div class='toggle-header'>
                             <h4>{{this.sectionHeaderLabel}}</h4>
-                            <h4 class='gh-portal-links-cell toggle' onclick={{action "toggleShowLinks"}}>{{this.toggleValue}}</h4>
+                            <h4 role="button" class='gh-portal-links-cell toggle' {{on "click" this.toggleShowLinks}}>{{this.toggleValue}}</h4>
                         </div>
                     </td>
                 </tr>
@@ -364,7 +364,7 @@
                                     data-portal
                                 {{/if}}
                             </div>
-                            <button type="button" {{action (perform this.copyStaticLink '')}} class="gh-portal-setting-copy">
+                            <button type="button" {{on "click" (fn this.copyStaticLink '')}} class="gh-portal-setting-copy">
                                 {{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice ""))}}
                                     {{svg-jar "check-circle" class="w3 v-mid mr2 stroke-darkgrey"}} Copied
                                 {{else}}
@@ -388,7 +388,7 @@
                                     data-portal="signin"
                                 {{/if}}
                             </div>
-                            <button type="button" {{action (perform this.copyStaticLink "signin")}} class="gh-portal-setting-copy">
+                            <button type="button" {{on "click" (fn this.copyStaticLink 'signin')}} class="gh-portal-setting-copy">
                                 {{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "signin"))}}
                                     {{svg-jar "check-circle" class="w3 v-mid mr2 stroke-darkgrey"}} Copied
                                 {{else}}
@@ -409,7 +409,7 @@
                                     data-portal="signup"
                                 {{/if}}
                             </div>
-                            <button type="button" {{action (perform this.copyStaticLink "signup")}} class="gh-portal-setting-copy">
+                            <button type="button" {{on "click" (fn this.copyStaticLink 'signup')}} class="gh-portal-setting-copy">
                                 {{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "signup"))}}
                                     {{svg-jar "check-circle" class="w3 v-mid mr2 stroke-darkgrey"}} Copied
                                 {{else}}
@@ -438,7 +438,7 @@
                                         @optionValuePath="name"
                                         @optionLabelPath="label"
                                         @value={{this.selectedProduct}}
-                                        @update={{action "setSelectedProduct"}}
+                                        @update={{this.setSelectedProduct}}
                                     />
                                     {{svg-jar "arrow-down-small"}}
                                 </span>
@@ -455,7 +455,7 @@
                                         data-portal="signup{{this.selectedProductIdPath}}/monthly"
                                     {{/if}}
                                 </div>
-                                <button type="button" {{action (perform this.copyProductSignupLink "monthly")}} class="gh-portal-setting-copy">
+                                <button type="button" {{on "click" (fn this.copyProductSignupLink 'monthly')}} class="gh-portal-setting-copy">
                                     {{#if (and this.copyProductSignupLink.isRunning (eq this.copiedSignupInterval "monthly"))}}
                                         {{svg-jar "check-circle" class="w3 v-mid mr2 stroke-darkgrey"}} Copied
                                     {{else}}
@@ -476,7 +476,7 @@
                                         data-portal="signup{{this.selectedProductIdPath}}/yearly"
                                     {{/if}}
                                 </div>
-                                <button type="button" {{action (perform this.copyProductSignupLink "yearly")}} class="gh-portal-setting-copy">
+                                <button type="button" {{on "click" (fn this.copyProductSignupLink 'yearly')}} class="gh-portal-setting-copy">
                                     {{#if (and this.copyProductSignupLink.isRunning (eq this.copiedSignupInterval "yearly"))}}
                                         {{svg-jar "check-circle" class="w3 v-mid mr2 stroke-darkgrey"}} Copied
                                     {{else}}
@@ -497,7 +497,7 @@
                                         data-portal="signup/free"
                                     {{/if}}
                                 </div>
-                                <button type="button" {{action (perform this.copyStaticLink "signup/free")}} class="gh-portal-setting-copy">
+                                <button type="button" {{on "click" (fn this.copyStaticLink "signup/free")}} class="gh-portal-setting-copy">
                                     {{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "signup/free"))}}
                                         {{svg-jar "check-circle" class="w3 v-mid mr2 stroke-darkgrey"}} Copied
                                     {{else}}
@@ -519,7 +519,7 @@
                                         data-portal="signup/monthly"
                                     {{/if}}
                                 </div>
-                                <button type="button" {{action (perform this.copyStaticLink "signup/monthly")}} class="gh-portal-setting-copy">
+                                <button type="button" {{on "click" (fn this.copyStaticLink "signup/monthly")}} class="gh-portal-setting-copy">
                                     {{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "signup/monthly"))}}
                                         {{svg-jar "check-circle" class="w3 v-mid mr2 stroke-darkgrey"}} Copied
                                     {{else}}
@@ -540,7 +540,7 @@
                                         data-portal="signup/yearly"
                                     {{/if}}
                                 </div>
-                                <button type="button" {{action (perform this.copyStaticLink "signup/yearly")}} class="gh-portal-setting-copy">
+                                <button type="button" {{on "click" (fn this.copyStaticLink "signup/yearly")}} class="gh-portal-setting-copy">
                                     {{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "signup/yearly"))}}
                                         {{svg-jar "check-circle" class="w3 v-mid mr2 stroke-darkgrey"}} Copied
                                     {{else}}
@@ -561,7 +561,7 @@
                                         data-portal="signup/free"
                                     {{/if}}
                                 </div>
-                                <button type="button" {{action (perform this.copyStaticLink "signup/free")}} class="gh-portal-setting-copy">
+                                <button type="button" {{on "click" (fn this.copyStaticLink "signup/free")}} class="gh-portal-setting-copy">
                                     {{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "signup/free"))}}
                                         {{svg-jar "check-circle" class="w3 v-mid mr2 stroke-darkgrey"}} Copied
                                     {{else}}
@@ -586,7 +586,7 @@
                                     data-portal="account"
                                 {{/if}}
                             </div>
-                            <button type="button" {{action (perform this.copyStaticLink "account")}} class="gh-portal-setting-copy">
+                            <button type="button" {{on "click" (fn this.copyStaticLink "account")}} class="gh-portal-setting-copy">
                                 {{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "account"))}}
                                     {{svg-jar "check-circle" class="w3 v-mid mr2 stroke-darkgrey"}} Copied
                                 {{else}}
@@ -607,7 +607,7 @@
                                     data-portal="account/plans"
                                 {{/if}}
                             </div>
-                            <button type="button" {{action (perform this.copyStaticLink "account/plans")}} class="gh-portal-setting-copy">
+                            <button type="button" {{on "click" (fn this.copyStaticLink "account/plans")}} class="gh-portal-setting-copy">
                                 {{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "account/plans"))}}
                                     {{svg-jar "check-circle" class="w3 v-mid mr2 stroke-darkgrey"}} Copied
                                 {{else}}
@@ -628,7 +628,7 @@
                                     data-portal="account/profile"
                                 {{/if}}
                             </div>
-                            <button type="button" {{action (perform this.copyStaticLink "account/profile")}} class="gh-portal-setting-copy">
+                            <button type="button" {{on "click" (fn this.copyStaticLink "account/profile")}} class="gh-portal-setting-copy">
                                 {{#if (and this.copyStaticLink.isRunning (eq this.copiedPrice "account/profile"))}}
                                     {{svg-jar "check-circle" class="w3 v-mid mr2 stroke-darkgrey"}} Copied
                                 {{else}}