Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Removed unused frontend offer endpoint (#14816)

Browse source 
refs https://github.com/TryGhost/Team/issues/1599

- portal now uses offer content api to read offer details from id
This commit is contained in:
Rishabh Garg 2022-05-13 17:20:09 +05:30 • committed by GitHub
parent 0f01aa6eea
commit 96bb441fb3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
core/server/services/members/middleware.js
View file

@ -2,7 +2,6 @@ const _ = require('lodash');
const logging = require('@tryghost/logging'); const logging = require('@tryghost/logging');
const membersService = require('./service'); const membersService = require('./service');
const models = require('../../models'); const models = require('../../models');
const offersService = require('../offers/service');
const urlUtils = require('../../../shared/url-utils'); const urlUtils = require('../../../shared/url-utils');
const {formattedMemberResponse} = require('./utils'); const {formattedMemberResponse} = require('./utils');
@ -56,14 +55,6 @@ const getMemberData = async function (req, res) {
} }
}; };
const getOfferData = async function (req, res) {
const offerId = req.params.id;
const offer = await offersService.api.getOffer({id: offerId});
return res.json({
offers: [offer]
});
};
const getMemberNewsletters = async function (req, res) { const getMemberNewsletters = async function (req, res) {
try { try {
const memberUuid = req.query.uuid; const memberUuid = req.query.uuid;
@ -210,7 +201,6 @@ module.exports = {
getIdentityToken, getIdentityToken,
getMemberNewsletters, getMemberNewsletters,
getMemberData, getMemberData,
getOfferData,
updateMemberData, updateMemberData,
updateMemberNewsletters, updateMemberNewsletters,
deleteSession deleteSession

4
core/server/web/members/app.js
View file

@ -38,11 +38,13 @@ module.exports = function setupMembersApp() {
membersApp.get('/api/member/newsletters', middleware.getMemberNewsletters); membersApp.get('/api/member/newsletters', middleware.getMemberNewsletters);
membersApp.put('/api/member/newsletters', bodyParser.json({limit: '1mb'}), middleware.updateMemberNewsletters); membersApp.put('/api/member/newsletters', bodyParser.json({limit: '1mb'}), middleware.updateMemberNewsletters);
// Get and update member data
membersApp.get('/api/member', middleware.getMemberData); membersApp.get('/api/member', middleware.getMemberData);
membersApp.put('/api/member', bodyParser.json({limit: '1mb'}), middleware.updateMemberData); membersApp.put('/api/member', bodyParser.json({limit: '1mb'}), middleware.updateMemberData);
membersApp.post('/api/member/email', bodyParser.json({limit: '1mb'}), (req, res) => membersService.api.middleware.updateEmailAddress(req, res)); membersApp.post('/api/member/email', bodyParser.json({limit: '1mb'}), (req, res) => membersService.api.middleware.updateEmailAddress(req, res));
// Manage session
membersApp.get('/api/session', middleware.getIdentityToken); membersApp.get('/api/session', middleware.getIdentityToken);
membersApp.get('/api/offers/:id', middleware.getOfferData);
membersApp.delete('/api/session', middleware.deleteSession); membersApp.delete('/api/session', middleware.deleteSession);
// NOTE: this is wrapped in a function to ensure we always go via the getter // NOTE: this is wrapped in a function to ensure we always go via the getter