Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Added support for selectable newsletters in custom sign up-forms (#18030)

Browse source 
refs https://github.com/TryGhost/Product/issues/3836
This commit is contained in:
Princi Vershwal 2023-09-08 18:30:07 +05:30 • committed by GitHub
parent 6306680993
commit 963d4002cd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/portal/src/data-attributes.js
View file

@ -23,7 +23,7 @@ export function formSubmitHandler({event, form, errorEl, siteUrl, submitHandler}
labels.push(labelInputs[i].value);
}
let newsletterInputs = event.target.querySelectorAll('input[data-members-newsletter]') || [];
let newsletterInputs = event.target.querySelectorAll('input[type=hidden][data-members-newsletter], input[type=checkbox][data-members-newsletter]:checked, input[type=radio][data-members-newsletter]:selected') || [];
for (let i = 0; i < newsletterInputs.length; ++i) {
newsletters.push({id: newsletterInputs[i].value});
}

2
apps/portal/src/tests/data-attributes.test.js
View file

@ -63,7 +63,7 @@ function getMockData({newsletterQuerySelectorResult = null} = {}) {
value: 'Gold'
}];
}
if (elem === 'input[data-members-newsletter]' && newsletterQuerySelectorResult) {
if (elem === 'input[type=hidden][data-members-newsletter], input[type=checkbox][data-members-newsletter]:checked, input[type=radio][data-members-newsletter]:selected' && newsletterQuerySelectorResult) {
return newsletterQuerySelectorResult;
}
}