Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Fixed email suppressed page portal tests

Browse source 
- tests were failing due to copy changes that made the test selectors fail to fetch the element
- for future, we should switch to using test ids here instead of text as they can easily change causing these failures
This commit is contained in:
Rishabh 2022-12-09 19:40:00 +05:30
parent 109bce8096
commit 960250e99e
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
ghost/portal/src/components/pages/EmailSuppressedPage.js
View file

@ -59,6 +59,7 @@ export default function EmailSuppressedPage() {
</div>
<ActionButton
dataTestId={'resubscribe-email'}
classes="gh-portal-confirm-button"
onClick={handleSubmit}
disabled={isRunning}

4
ghost/portal/src/components/pages/EmailSuppressedPage.test.js
View file

@ -6,8 +6,8 @@ const setup = (overrides) => {
const {mockOnActionFn, ...utils} = render(
<EmailSuppressedPage />
);
const resubscribeBtn = utils.queryByRole('button', {name: 'Resubscribe your email'});
const title = utils.queryByText('Email disabled');
const resubscribeBtn = utils.queryByRole('button', {name: 'Re-enable emails'});
const title = utils.queryByText('Emails disabled');
return {
resubscribeBtn,