From 937df2c7ecef09fcd585a6af6157d5105495a3b1 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Mon, 15 Jun 2020 09:24:08 +0100 Subject: [PATCH] =?UTF-8?q?=E2=99=BF=EF=B8=8F=20Added=20blank=20alt=20attr?= =?UTF-8?q?ibutes=20to=20images=20when=20no=20alt=20text=20is=20provided?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit no issue - screen readers often resort to reading out the filename when alt text is not provided which is not useful. By adding `alt=""` (or just `alt`) to `` elements the image is skipped by screen readers providing a smoother experience - updated `@tryghost/kg-default-cards` which contains above change for `image` and `gallery` cards --- package.json | 2 +- test/regression/models/model_posts_spec.js | 2 +- test/unit/lib/mobiledoc_spec.js | 2 +- yarn.lock | 8 ++++---- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index 28f06b6c9a..9e96cb1094 100644 --- a/package.json +++ b/package.json @@ -48,7 +48,7 @@ "@tryghost/image-transform": "0.2.4", "@tryghost/kg-card-factory": "2.1.1", "@tryghost/kg-default-atoms": "2.0.1", - "@tryghost/kg-default-cards": "2.1.0", + "@tryghost/kg-default-cards": "2.2.0", "@tryghost/kg-markdown-html-renderer": "2.0.1", "@tryghost/kg-mobiledoc-html-renderer": "3.0.1", "@tryghost/magic-link": "^0.4.8", diff --git a/test/regression/models/model_posts_spec.js b/test/regression/models/model_posts_spec.js index 70de337d58..38a62f14fa 100644 --- a/test/regression/models/model_posts_spec.js +++ b/test/regression/models/model_posts_spec.js @@ -1135,7 +1135,7 @@ describe('Post Model', function () { models.Post.add(post, context).then((createdPost) => { createdPost.get('mobiledoc').should.equal('{"version":"0.3.1","atoms":[],"cards":[["image",{"src":"/content/images/card.jpg"}]],"markups":[["a",["href","/test"]]],"sections":[[1,"p",[[0,[0],1,"Testing"]]],[10,0]]}'); - createdPost.get('html').should.equal('

Testing

'); + createdPost.get('html').should.equal('

Testing

'); createdPost.get('custom_excerpt').should.equal('Testing links in custom excerpts'); createdPost.get('codeinjection_head').should.equal(''); createdPost.get('codeinjection_foot').should.equal(''); diff --git a/test/unit/lib/mobiledoc_spec.js b/test/unit/lib/mobiledoc_spec.js index d7e44fd4e5..137eaf7c45 100644 --- a/test/unit/lib/mobiledoc_spec.js +++ b/test/unit/lib/mobiledoc_spec.js @@ -68,7 +68,7 @@ describe('lib/mobiledoc', function () { }; mobiledocLib.mobiledocHtmlRenderer.render(mobiledoc) - .should.eql('

One
Two

Markdown card

\n

Some markdown

\n

Three

Birdies

Four

HTML card

\n

Some HTML

Embed card

'); + .should.eql('

One
Two

Markdown card

\n

Some markdown

\n

Three

Birdies

Four

HTML card

\n

Some HTML

Embed card

'); }); }); }); diff --git a/yarn.lock b/yarn.lock index 9c8c751707..a584b92eaf 100644 --- a/yarn.lock +++ b/yarn.lock @@ -443,10 +443,10 @@ resolved "https://registry.yarnpkg.com/@tryghost/kg-default-atoms/-/kg-default-atoms-2.0.1.tgz#3223ef5210d73af02c53795e5a5f1a9c5fc5bd92" integrity sha512-0/Fx98ZIj/gyPglKg9HQP+cKPSBpbue1pnzh3E8hR4WXzqnSWMFA8VTUyMeI+8oNwxkxhZrWt5KifngHbBfw2A== -"@tryghost/kg-default-cards@2.1.0": - version "2.1.0" - resolved "https://registry.yarnpkg.com/@tryghost/kg-default-cards/-/kg-default-cards-2.1.0.tgz#a218079d2e6662fe5b0117740faecf94cde6fd35" - integrity sha512-8OKPFm210ACzjojmQLPCcRVNattc66Ub+Re5QsG6x09q7+xNV4IiTRt7L+pU4UizmHQ7y6jOFTWXH35az0O1Qw== +"@tryghost/kg-default-cards@2.2.0": + version "2.2.0" + resolved "https://registry.yarnpkg.com/@tryghost/kg-default-cards/-/kg-default-cards-2.2.0.tgz#d85dd5b826af3148ec893ff943933ac5315653ee" + integrity sha512-ENxrtyS959HV1gbX2eMVGgXhjmpbdvYkbNK/ohME74lIL1czCVpZBaziG2g2Lileknh6NbCxU0VDSQs2zZrtBg== dependencies: "@tryghost/kg-markdown-html-renderer" "^2.0.1" "@tryghost/url-utils" "^0.6.14"