From 929d05a33b39b97f4a2ab7db38fedc5332a8db91 Mon Sep 17 00:00:00 2001
From: Ronald Langeveld <hi@ronaldlangeveld.com>
Date: Thu, 5 Oct 2023 15:20:18 +0700
Subject: [PATCH] Fixed sidebar order of Newsletters section - X (#18493)

refs https://ghost.slack.com/archives/C0568LN2CGJ/p1696490815762949

- Fixed a tiny issue where the Sidebar Navigation doesn't align with the
newsletter options.
- Got rid of some unused commented out code that's not needed.
---
 apps/admin-x-settings/src/components/Settings.tsx | 12 ------------
 apps/admin-x-settings/src/components/Sidebar.tsx  |  2 +-
 2 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/apps/admin-x-settings/src/components/Settings.tsx b/apps/admin-x-settings/src/components/Settings.tsx
index 9639bb9001..984a651b22 100644
--- a/apps/admin-x-settings/src/components/Settings.tsx
+++ b/apps/admin-x-settings/src/components/Settings.tsx
@@ -5,18 +5,6 @@ import EmailSettings from './settings/email/EmailSettings';
 import GeneralSettings from './settings/general/GeneralSettings';
 import MembershipSettings from './settings/membership/MembershipSettings';
 import SiteSettings from './settings/site/SiteSettings';
-// import UnsplashSearchModal from '../utils/unsplash/UnsplashSearchModal';
-
-// const API_VERSION = 'v1';
-// const API_TOKEN = '8672af113b0a8573edae3aa3713886265d9bb741d707f6c01a486cde8c278980';
-
-// export const defaultHeaders = {
-//     Authorization: `Client-ID ${API_TOKEN}`,
-//     'Accept-Version': API_VERSION,
-//     'Content-Type': 'application/json',
-//     'App-Pragma': 'no-cache',
-//     'X-Unsplash-Cache': true
-// };
 
 const Settings: React.FC = () => {
     return (
diff --git a/apps/admin-x-settings/src/components/Sidebar.tsx b/apps/admin-x-settings/src/components/Sidebar.tsx
index 69acdcfae5..56ede56470 100644
--- a/apps/admin-x-settings/src/components/Sidebar.tsx
+++ b/apps/admin-x-settings/src/components/Sidebar.tsx
@@ -106,8 +106,8 @@ const Sidebar: React.FC = () => {
                     <SettingNavItem keywords={emailSearchKeywords.enableNewsletters} navid='enable-newsletters' title="Newsletter sending" onClick={handleSectionClick} />
                     {newslettersEnabled !== 'disabled' && (
                         <>
-                            <SettingNavItem keywords={emailSearchKeywords.newsletters} navid='newsletters' title="Newsletters" onClick={handleSectionClick} />
                             <SettingNavItem keywords={emailSearchKeywords.defaultRecipients} navid='default-recipients' title="Default recipients" onClick={handleSectionClick} />
+                            <SettingNavItem keywords={emailSearchKeywords.newsletters} navid='newsletters' title="Newsletters" onClick={handleSectionClick} />
                             {!config.mailgunIsConfigured && <SettingNavItem keywords={emailSearchKeywords.mailgun} navid='mailgun' title="Mailgun settings" onClick={handleSectionClick} />}
                         </>
                     )}