Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Fixed email debug page always showing error + breadcrumb

Browse source
This commit is contained in:
Simon Backx 2022-12-02 14:45:06 +01:00
parent 9b276e6aa2
commit 928a73c536
2 changed files with 14 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
ghost/admin/app/components/posts/debug.hbs
View file

@ -6,7 +6,7 @@
Posts
</LinkTo>
{{svg-jar "arrow-right-small"}}
<LinkTo @route="posts.analytics" @model={{@model.id}}>
<LinkTo @route="posts.analytics" @model={{this.post.id}}>
Analytics
</LinkTo>
{{svg-jar "arrow-right-small"}}
@ -40,14 +40,16 @@
{{/let}}
</div>
</div>
<div class="gh-box gh-box-error gh-box-tip gh-email-debug-error">
{{svg-jar "warning"}}
<div class="gh-email-debug-errortext">
<h4>Something went wrong!</h4>
<p class="mb0">{{this.emailError.message}}</p>
{{#if (eq this.post.email.status 'failed') }}
<div class="gh-box gh-box-error gh-box-tip gh-email-debug-error">
{{svg-jar "warning"}}
<div class="gh-email-debug-errortext">
<h4>Something went wrong!</h4>
<p class="mb0">{{this.emailError.message}}</p>
</div>
<button type="button" class="gh-btn gh-btn-primary gh-btn-icon gh-btn-red ember-view self-center"><span>Retry</span></button>
</div>
<button type="button" class="gh-btn gh-btn-primary gh-btn-icon gh-btn-red ember-view self-center"><span>Retry</span></button>
</div>
{{/if}}
</div>
</GhCanvasHeader>
@ -94,7 +96,7 @@
{{#unless this.permanentFailureData}}
<tr>
<td>
<div class="gh-email-debug-empty-list">No permanent failures.</div>
<div class="gh-email-debug-empty-list">No permanent failures.</div>
</td>
</tr>
{{/unless}}
@ -233,7 +235,7 @@
{{#unless this.temporaryFailureData}}
<tr>
<td>
<div class="gh-email-debug-empty-list">No temporary failures.</div>
<div class="gh-email-debug-empty-list">No temporary failures.</div>
</td>
</tr>
{{/unless}}
@ -532,4 +534,4 @@
</tabs.tabPanel>
</Tabs::Tabs>
</section>
</section>

7
ghost/admin/app/routes/posts/debug.js
View file

@ -13,12 +13,7 @@ export default class Debug extends AuthenticatedRoute {
'authors.roles',
'email',
'tiers',
'newsletter',
'count.conversions',
'count.clicks',
'sentiment',
'count.positive_feedback',
'count.negative_feedback'
'newsletter'
].join(',')
};