Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Deferred URL generation until after filter

Browse source 
- it turns out we it the false case of this if-statement quite a lot,
  and _generateUrl is heavy enough that we should try and do it less
- by moving it into the if-statement, we cut 4% CPU time from boot on
  heavy sites
This commit is contained in:
Daniel Lockyer 2024-10-14 10:20:15 +02:00 • committed by Daniel Lockyer
parent 70eb96f33a
commit 90fbbe135f
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ghost/core/core/server/services/url/UrlGenerator.js
View file

@ -170,11 +170,10 @@ class UrlGenerator {
return false;
}
const url = this._generateUrl(resource);
// CASE 1: route has no custom filter, it will own the resource for sure
// CASE 2: find out if my filter matches the resource
if ((!this.filter) || (this.nql.queryJSON(resource.data))) {
const url = this._generateUrl(resource);
this.urls.add({
url: url,
generatorId: this.uid,

2
ghost/core/test/unit/server/services/url/UrlGenerator.test.js
View file

@ -263,7 +263,7 @@ describe('Unit: services/url/UrlGenerator', function () {
urlGenerator._try(resource);
urlGenerator._generateUrl.calledOnce.should.be.true();
urlGenerator._generateUrl.calledOnce.should.be.false();
urlGenerator._resourceListeners.called.should.be.false();
urls.add.called.should.be.false();
resource.reserve.called.should.be.false();