Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Fix copy to "Post excerpt" in newsletter settings (#20344)

Browse source 
MOM-209

Currently if the "Show post excerpt inline" is on we show "Subtitle" in
newsletter settings, it should always be "Post excerpt" to avoid
confusion.
This commit is contained in:
Peter Zimon 2024-06-06 08:40:52 +02:00 • committed by GitHub
parent a7a1166310
commit 909f2fa028
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
apps/admin-x-settings/src/components/settings/email/newsletters/NewsletterDetailModal.tsx
View file

@ -104,7 +104,6 @@ const Sidebar: React.FC<{
const [selectedTab, setSelectedTab] = useState('generalSettings'); const [selectedTab, setSelectedTab] = useState('generalSettings');
const hasEmailCustomization = useFeatureFlag('emailCustomization'); const hasEmailCustomization = useFeatureFlag('emailCustomization');
const hasNewsletterExcerpt = useFeatureFlag('newsletterExcerpt'); const hasNewsletterExcerpt = useFeatureFlag('newsletterExcerpt');
const hasEditorSubtitle = useFeatureFlag('editorExcerpt');
const {localSettings} = useSettingGroup(); const {localSettings} = useSettingGroup();
const [siteTitle] = getSettingValues(localSettings, ['title']) as string[]; const [siteTitle] = getSettingValues(localSettings, ['title']) as string[];
const handleError = useHandleError(); const handleError = useHandleError();
@ -423,7 +422,7 @@ const Sidebar: React.FC<{
<Toggle <Toggle
checked={newsletter.show_excerpt} checked={newsletter.show_excerpt}
direction="rtl" direction="rtl"
label={hasEditorSubtitle ? 'Subtitle' : 'Post excerpt'} label="Post excerpt"
onChange={e => updateNewsletter({show_excerpt: e.target.checked})} onChange={e => updateNewsletter({show_excerpt: e.target.checked})}
/> />
} }