From 909c8b53a8bad4884b9d6add2ddea6db67b72149 Mon Sep 17 00:00:00 2001
From: Chris Raible <chris@ghost.org>
Date: Wed, 11 Oct 2023 04:06:03 -0700
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20bug=20causing=20sites=20?=
 =?UTF-8?q?with=20many=20snippets=20to=20be=20rate=20limited=20(#18568)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

refs TryGhost/Product#4022

- This block of code converts any snippets that are only in mobiledoc to lexical locally in the editor, then sends a PUT request for each snippet to update it on the server
- For sites with > 50 snippets, these PUT requests were triggering rate limits on Pro of 50 req/s
- This change is a temp fix to add a 100ms sleep between these requests to stay under the 50 req/s limit
- Longer term, we may introduce a migration that will convert all snippets, or modify the editor to somehow lazily convert the snippets when needed, but this temp fix should resolve the rate limiting issue for the time being
---
 ghost/admin/app/controllers/lexical-editor.js | 32 ++++++++++++++-----
 1 file changed, 24 insertions(+), 8 deletions(-)

diff --git a/ghost/admin/app/controllers/lexical-editor.js b/ghost/admin/app/controllers/lexical-editor.js
index 54f3dc0929..ac72c0da01 100644
--- a/ghost/admin/app/controllers/lexical-editor.js
+++ b/ghost/admin/app/controllers/lexical-editor.js
@@ -817,22 +817,34 @@ export default class LexicalEditorController extends Controller {
         this.syncMobiledocSnippets();
     }
 
+    sleep(ms) {
+        return new Promise((r) => {
+            setTimeout(r, ms);
+        });
+    }
+
     @action
     async syncMobiledocSnippets() {
         const snippets = this.store.peekAll('snippet');
 
         // very early in the beta we had a bug where lexical snippets were saved with double-encoded JSON
         // we fix that here by re-saving any snippets that are still in that state
-        const snippetFixSaves = [];
-        snippets.forEach((snippet) => {
+        for (let i = 0; i < snippets.length; i++) {
+            const snippet = snippets.objectAt(i);
             if (typeof snippet.lexical === 'string') {
                 try {
                     snippet.lexical = JSON.parse(snippet.lexical);
                     snippet.mobiledoc = {};
-                    snippetFixSaves.push(snippet.save());
+                    await snippet.save();
+                    // Temp fix: Timeout for 100 ms between requests to avoid hitting rate limit (50req/s)
+                    // refs https://github.com/TryGhost/Product/issues/4022
+                    await this.sleep(100);
                 } catch (e) {
                     snippet.lexical = null;
-                    snippetFixSaves.push(snippet.save());
+                    await snippet.save();
+                    // Temp fix: Timeout for 100 ms between requests to avoid hitting rate limit (50req/s)
+                    // refs https://github.com/TryGhost/Product/issues/4022
+                    await this.sleep(100);
 
                     console.error(e); // eslint-disable-line no-console
 
@@ -845,10 +857,10 @@ export default class LexicalEditorController extends Controller {
                     }
                 }
             }
-        });
-        await Promise.all(snippetFixSaves);
+        }
 
-        snippets.forEach((snippet) => {
+        for (let i = 0; i < snippets.length; i++) {
+            const snippet = snippets.objectAt(i);
             if (!snippet.lexical || snippet.lexical.syncedAt && moment.utc(snippet.lexical.syncedAt).isBefore(snippet.updatedAtUTC)) {
                 const serializedLexical = mobiledocToLexical(JSON.stringify(snippet.mobiledoc));
 
@@ -875,8 +887,12 @@ export default class LexicalEditorController extends Controller {
 
                 // kick off a background save, we already have .lexical updated which is what we need
                 snippet.save();
+
+                // Temp fix: Timeout for 100 ms between requests to avoid hitting rate limit (50req/s)
+                // refs https://github.com/TryGhost/Product/issues/4022
+                await this.sleep(100);
             }
-        });
+        }
     }
 
     /* Public methods --------------------------------------------------------*/