Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Removed use of deprecated new Error() syntax

Browse source 
refs 2f1123d6ca
refs 6f1a3e1774

- The use of new Error() has been deprecated. Refactoring the migration  to use `createIrreversibleMigration` made most sense to have central error handling for migration which are not meant to be reverted.
This commit is contained in:
Naz 2021-07-14 12:16:44 +04:00
parent bfb899b293
commit 8f5d6ebf8c
1 changed files with 20 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
core/server/data/migrations/versions/3.0/14-remove-subscribers-flag.js
View file

@ -1,28 +1,24 @@
const logging = require('@tryghost/logging'); const logging = require('@tryghost/logging');
const {createIrreversibleMigration} = require('../../utils');
module.exports = { module.exports = createIrreversibleMigration(async (knex) => {
async up({connection}) { let result = await knex('settings')
let result = await connection('settings') .where('key', '=', 'labs')
.where('key', '=', 'labs') .select('value');
.select('value');
if (!result || !result[0]) { if (!result || !result[0]) {
logging.warn(`Could not find labs setting`); logging.warn(`Could not find labs setting`);
result = [{}]; result = [{}];
}
const labs = JSON.parse(result[0].value);
labs.members = !!labs.members || !!labs.subscribers;
logging.info(`Updating labs setting removing subscribers (was ${labs.subscribers}) settings members to ${labs.members}`);
labs.subscribers = undefined;
await connection('settings')
.where('key', '=', 'labs')
.update('value', JSON.stringify(labs));
},
async down() {
throw new Error();
} }
};
const labs = JSON.parse(result[0].value);
labs.members = !!labs.members || !!labs.subscribers;
logging.info(`Updating labs setting removing subscribers (was ${labs.subscribers}) settings members to ${labs.members}`);
labs.subscribers = undefined;
await knex('settings')
.where('key', '=', 'labs')
.update('value', JSON.stringify(labs));
});