From 8df5b1a9749911a201cd9bad69db62e217252e15 Mon Sep 17 00:00:00 2001
From: Daniel Lockyer <hi@daniellockyer.com>
Date: Fri, 10 Mar 2023 09:54:46 +0100
Subject: [PATCH] Refactored `events` wrapper into class
- we have our own class in order to add the `hasRegisteredListener`
function
- this commit refactors the implementation to use the class syntactic
sugar, which means we get better editor autocomplete
- this shouldn't change the functionality
---
ghost/core/core/server/lib/common/events.js | 39 +++++++++------------
1 file changed, 16 insertions(+), 23 deletions(-)
diff --git a/ghost/core/core/server/lib/common/events.js b/ghost/core/core/server/lib/common/events.js
index 2d9845425c..c650eae6e4 100644
--- a/ghost/core/core/server/lib/common/events.js
+++ b/ghost/core/core/server/lib/common/events.js
@@ -12,29 +12,22 @@
*/
const events = require('events');
-const util = require('util');
-let EventRegistry;
-let EventRegistryInstance;
-EventRegistry = function () {
- events.EventEmitter.call(this);
-};
+class EventRegistry extends events.EventEmitter {
+ /**
+ * This is method is semi-hack to make sure listeners are only registered once
+ * during the lifetime of the process. And example problem it solves is
+ * registering duplicate listeners between Ghost instance reboots when running tests.
+ * @param {String} eventName
+ * @param {String} listenerName named function name registered as a listener for the event
+ * @returns {Boolean}
+ */
+ hasRegisteredListener(eventName, listenerName) {
+ return !!(this.listeners(eventName).find(listener => (listener.name === listenerName)));
+ }
+}
-util.inherits(EventRegistry, events.EventEmitter);
+const eventRegistryInstance = new EventRegistry();
+eventRegistryInstance.setMaxListeners(100);
-/**
- * This is method is semi-hack to make sure listeners are only registered once
- * during the lifetime of the process. And example problem it solves is
- * registering duplicate listeners between Ghost instance reboots when running tests.
- * @param {String} eventName
- * @param {String} listenerName named function name registered as a listener for the event
- * @returns {Boolean}
- */
-EventRegistry.prototype.hasRegisteredListener = function (eventName, listenerName) {
- return !!(this.listeners(eventName).find(listener => (listener.name === listenerName)));
-};
-
-EventRegistryInstance = new EventRegistry();
-EventRegistryInstance.setMaxListeners(100);
-
-module.exports = EventRegistryInstance;
+module.exports = eventRegistryInstance;