Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

🐛 Fixed invalid imported subscribers count (#10229)

Browse source 
closes #9987

- Fixed the count of invalid records when importing single column csv of subscribers
This commit is contained in:
Sumedh Nimkarde 2018-12-04 01:15:55 +05:30 • committed by Naz Gargol
parent fc21b25895
commit 8b816af1c2
4 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
core/server/lib/fs/read-csv.js
View file

@ -26,11 +26,6 @@ module.exports = function readCSV(options) {
result[columnsToExtract[0].name] = value[headers[0]];
return result;
});
// Add first row
result = {};
result[columnsToExtract[0].name] = headers[0];
results = [result].concat(results);
} else {
// If there are multiple columns in csv file
// try to match headers using lookup value

2
core/test/functional/api/v0.1/subscribers_spec.js
View file

@ -229,7 +229,7 @@ describe('Subscribers API', function () {
jsonResponse.meta.stats.imported.should.equal(2);
jsonResponse.meta.stats.duplicates.should.equal(0);
jsonResponse.meta.stats.invalid.should.equal(1); // TODO: should return 0
jsonResponse.meta.stats.invalid.should.equal(0);
});
});
});

2
core/test/functional/api/v2/admin/subscribers_spec.js
View file

@ -223,7 +223,7 @@ describe('Subscribers API', function () {
jsonResponse.meta.stats.imported.should.equal(2);
jsonResponse.meta.stats.duplicates.should.equal(0);
jsonResponse.meta.stats.invalid.should.equal(1); // TODO: should return 0
jsonResponse.meta.stats.invalid.should.equal(0);
});
});
});

7
core/test/unit/lib/fs/read-csv_spec.js
View file

@ -10,10 +10,9 @@ describe('lib/fs: read csv', function () {
columnsToExtract: [{name: 'email', lookup: /email/i}]
}).then(function (result) {
should.exist(result);
result.length.should.eql(3);
result[0].email.should.eql('email');
result[1].email.should.eql('jbloggs@example.com');
result[2].email.should.eql('test@example.com');
result.length.should.eql(2);
result[0].email.should.eql('jbloggs@example.com');
result[1].email.should.eql('test@example.com');
done();
}).catch(done);
});