From 12d53dead6e81008ad529ea0e9195bec85b65923 Mon Sep 17 00:00:00 2001
From: John O'Nolan <john@onolan.org>
Date: Mon, 26 Aug 2013 02:29:44 +0200
Subject: [PATCH] Move pagination to class rather than ID

Pagination could conceivably be used in more than one place on a page (eg. both top and bottom). For that reason it should probably have a class rather than an ID.
---
 core/server/helpers/tpl/pagination.hbs        | 2 +-
 core/test/unit/frontend_helpers_index_spec.js | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/core/server/helpers/tpl/pagination.hbs b/core/server/helpers/tpl/pagination.hbs
index ae91a134a0..2930b256c2 100644
--- a/core/server/helpers/tpl/pagination.hbs
+++ b/core/server/helpers/tpl/pagination.hbs
@@ -1,5 +1,5 @@
 
-<nav id="pagination" role="pagination">
+<nav class="pagination" role="pagination">
     {{#if next}}
         <div class="previous-page"><a href="/page/{{next}}/">Older Posts →</a></div>
     {{/if}}
diff --git a/core/test/unit/frontend_helpers_index_spec.js b/core/test/unit/frontend_helpers_index_spec.js
index ee7237f43f..1df5e41cfb 100644
--- a/core/test/unit/frontend_helpers_index_spec.js
+++ b/core/test/unit/frontend_helpers_index_spec.js
@@ -249,7 +249,7 @@ describe('Core Helpers', function () {
                 rendered = handlebars.helpers.pagination.call({pagination: {page: 1, prev: undefined, next: undefined, limit: 15, total: 8, pages: 1}});
                 should.exist(rendered);
                 // strip out carriage returns and compare.
-                rendered.string.replace(/\r/g, '').should.equal('\n<nav id="pagination" role="pagination">\n    \n    <div class="page-number">Page 1<span class="extended"> of 1</span></div>\n    \n</nav>');
+                rendered.string.replace(/\r/g, '').should.equal('\n<nav class="pagination" role="pagination">\n    \n    <div class="page-number">Page 1<span class="extended"> of 1</span></div>\n    \n</nav>');
                 done();
             }).then(null, done);
         });
@@ -260,7 +260,7 @@ describe('Core Helpers', function () {
                 rendered = handlebars.helpers.pagination.call({pagination: {page: 1, prev: undefined, next: 2, limit: 15, total: 8, pages: 3}});
                 should.exist(rendered);
                 // strip out carriage returns and compare.
-                rendered.string.replace(/\r/g, '').should.equal('\n<nav id="pagination" role="pagination">\n    \n        <div class="previous-page"><a href="/page/2/">Older Posts →</a></div>\n    \n    <div class="page-number">Page 1<span class="extended"> of 3</span></div>\n    \n</nav>');
+                rendered.string.replace(/\r/g, '').should.equal('\n<nav class="pagination" role="pagination">\n    \n        <div class="previous-page"><a href="/page/2/">Older Posts →</a></div>\n    \n    <div class="page-number">Page 1<span class="extended"> of 3</span></div>\n    \n</nav>');
                 done();
             }).then(null, done);
         });
@@ -271,7 +271,7 @@ describe('Core Helpers', function () {
                 rendered = handlebars.helpers.pagination.call({pagination: {page: 2, prev: 1, next: 3, limit: 15, total: 8, pages: 3}});
                 should.exist(rendered);
                 // strip out carriage returns and compare.
-                rendered.string.replace(/\r/g, '').should.equal('\n<nav id="pagination" role="pagination">\n    \n        <div class="previous-page"><a href="/page/3/">Older Posts →</a></div>\n    \n    <div class="page-number">Page 2<span class="extended"> of 3</span></div>\n    \n        <div class="next-page"><a href="/page/1/">← Newer Posts</a></div>\n    \n</nav>');
+                rendered.string.replace(/\r/g, '').should.equal('\n<nav class="pagination" role="pagination">\n    \n        <div class="previous-page"><a href="/page/3/">Older Posts →</a></div>\n    \n    <div class="page-number">Page 2<span class="extended"> of 3</span></div>\n    \n        <div class="next-page"><a href="/page/1/">← Newer Posts</a></div>\n    \n</nav>');
                 done();
             }).then(null, done);
         });
@@ -282,7 +282,7 @@ describe('Core Helpers', function () {
                 rendered = handlebars.helpers.pagination.call({pagination: {page: 3, prev: 2, next: undefined, limit: 15, total: 8, pages: 3}});
                 should.exist(rendered);
                 // strip out carriage returns and compare.
-                rendered.string.replace(/\r/g, '').should.equal('\n<nav id="pagination" role="pagination">\n    \n    <div class="page-number">Page 3<span class="extended"> of 3</span></div>\n    \n        <div class="next-page"><a href="/page/2/">← Newer Posts</a></div>\n    \n</nav>');
+                rendered.string.replace(/\r/g, '').should.equal('\n<nav class="pagination" role="pagination">\n    \n    <div class="page-number">Page 3<span class="extended"> of 3</span></div>\n    \n        <div class="next-page"><a href="/page/2/">← Newer Posts</a></div>\n    \n</nav>');
                 done();
             }).then(null, done);
         });