Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Removed settings populateDefaults pre-migration

Browse source 
refs https://github.com/TryGhost/Ghost/issues/12568
refs 5fbc40430b

- Having populateDefaults run before migrations creates a chicken and egg problem where populate defaults can create records that are "non-migratable" as happened in https://github.com/TryGhost/Ghost/issues/12026
This commit is contained in:
Naz 2021-02-01 19:29:13 +13:00 • committed by naz
parent f1cf7b125f
commit 864fcd8a0c
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
core/server/data/migrations/hooks/migrate/before.js
View file

@ -3,8 +3,5 @@ const models = require('../../../../models');
module.exports = function before() {
models.init();
return dbBackup.backup().then(() => {
// ensure that our default settings are created to limit possible db states in migrations
return models.Settings.populateDefaults();
});
return dbBackup.backup();
};