Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-17 23:44:39 -05:00
Code Issues Activity

Shorter notifications

Browse source 
Basic notifications are unnecessarily verbose and, in some instances, even cause line-wrapping to occur. This change shortens them to short, concsise statements to indicate what action has taken place.
This commit is contained in:
John O'Nolan 2014-07-31 19:19:47 +03:00
parent c5fbe2def3
commit 854a3041fd
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
core/client/mixins/editor-base-controller.js
View file

@ -139,12 +139,12 @@ var EditorControllerMixin = Ember.Mixin.create(MarkerManager, {
errors: { errors: {
post: { post: {
published: { published: {
'published': 'Your post could not be updated.', 'published': 'Update failed.',
'draft': 'Your post could not be saved as a draft.' 'draft': 'Saving failed.'
}, },
draft: { draft: {
'published': 'Your post could not be published.', 'published': 'Publish failed.',
'draft': 'Your post could not be saved as a draft.' 'draft': 'Saving failed.'
} }
} }
@ -153,12 +153,12 @@ var EditorControllerMixin = Ember.Mixin.create(MarkerManager, {
success: { success: {
post: { post: {
published: { published: {
'published': 'Your post has been updated.', 'published': 'Updated.',
'draft': 'Your post has been saved as a draft.' 'draft': 'Saved.'
}, },
draft: { draft: {
'published': 'Your post has been published.', 'published': 'Published!',
'draft': 'Your post has been saved as a draft.' 'draft': 'Saved.'
} }
} }
} }

2
core/test/functional/client/editor_test.js
View file

@ -282,7 +282,7 @@ CasperTest.begin('Post settings menu', 30, function suite(test) {
casper.waitForSelector('.notification-success', function waitForSuccess() { casper.waitForSelector('.notification-success', function waitForSuccess() {
test.assert(true, 'got success notification'); test.assert(true, 'got success notification');
test.assertSelectorHasText('.notification-success', 'Your post has been saved as a draft.'); test.assertSelectorHasText('.notification-success', 'Saved.');
casper.click('.notification-success a.close'); casper.click('.notification-success a.close');
}, function onTimeout() { }, function onTimeout() {
test.assert(false, 'No success notification'); test.assert(false, 'No success notification');