From 84e602640810dc1059cb54c2cf712857bba6d12b Mon Sep 17 00:00:00 2001
From: "Fabien \"egg\" O'Carroll" <fabien@allou.is>
Date: Fri, 1 Sep 2023 13:24:46 +0700
Subject: [PATCH] Fixed Offer entity types in OfferBookshelfRepository

JSDoc has a problem with using values as types across repositories, rather than
getting `Offer` as the type we end up with `typeof Offer` as the type - which is
incorrect. Instead we use `import` syntax inside of JSDoc which resolves correctly
---
 .../server/services/offers/OfferBookshelfRepository.js    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/ghost/core/core/server/services/offers/OfferBookshelfRepository.js b/ghost/core/core/server/services/offers/OfferBookshelfRepository.js
index 0c104c68f5..91aeb1fd3f 100644
--- a/ghost/core/core/server/services/offers/OfferBookshelfRepository.js
+++ b/ghost/core/core/server/services/offers/OfferBookshelfRepository.js
@@ -91,7 +91,7 @@ class OfferBookshelfRepository {
      * @private
      * @param {import('bookshelf').Model<any>} model
      * @param {BaseOptions} options
-     * @returns {Promise<Offer>}
+     * @returns {Promise<import('@tryghost/members-offers').Offer>}
      */
     async mapToOffer(model, options) {
         const json = model.toJSON();
@@ -123,7 +123,7 @@ class OfferBookshelfRepository {
     /**
      * @param {string} id
      * @param {BaseOptions} [options]
-     * @returns {Promise<Offer>}
+     * @returns {Promise<import('@tryghost/members-offers').Offer>}
      */
     async getById(id, options) {
         const model = await this.OfferModel.findOne({id}, {
@@ -141,7 +141,7 @@ class OfferBookshelfRepository {
     /**
      * @param {string} id stripe_coupon_id
      * @param {BaseOptions} [options]
-     * @returns {Promise<Offer>}
+     * @returns {Promise<import('@tryghost/members-offers').Offer>}
      */
     async getByStripeCouponId(id, options) {
         const model = await this.OfferModel.findOne({stripe_coupon_id: id}, {
@@ -158,7 +158,7 @@ class OfferBookshelfRepository {
 
     /**
      * @param {ListOptions} options
-     * @returns {Promise<Offer[]>}
+     * @returns {Promise<import('@tryghost/members-offers').Offer[]>}
      */
     async getAll(options) {
         const models = await this.OfferModel.findAll({