Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

🐛 Fixed missing stripe connected check on boot (#12992)

Browse source 
refs https://github.com/TryGhost/Team/issues/598
refs https://github.com/TryGhost/Ghost/commit/5cdf910e

As part of the changes to disallow sites with starting up without https when they are connected to stripe, the conditional missed the check for stripe connection. As a result we were erroring in boot sequence for all sites starting without https irrespective if they are connected to Stripe or not which is incorrect. This fixes the `init` check for members service to only error for non-https sites if they are connected to Stripe.
This commit is contained in:
Rishabh Garg 2021-05-27 23:03:03 +05:30 • committed by GitHub
parent 898e1cb956
commit 83c0cbb516
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/server/services/members/service.js
View file

@ -74,7 +74,7 @@ const membersService = {
}
} else {
const siteUrl = urlUtils.getSiteUrl();
if (!/^https/.test(siteUrl)) {
if (!/^https/.test(siteUrl) && membersConfig.isStripeConnected()) {
throw new Error('Cannot run Ghost without SSL when Stripe is connected. Please update your url config to use "https://"');
}
}