From 83702c7e86fae8fbb18b919d568e52ae816ceb41 Mon Sep 17 00:00:00 2001 From: Daniel Lockyer Date: Wed, 17 Aug 2022 14:43:01 +0200 Subject: [PATCH] Added `resource` to data available to audit log - this allows us to hydrate the post title into the UI - needs work to support non-post and missing resources --- .../app/helpers/parse-audit-log-event.js | 4 + .../app/templates/settings/audit-log.hbs | 101 +++++++++--------- 2 files changed, 55 insertions(+), 50 deletions(-) diff --git a/ghost/admin/app/helpers/parse-audit-log-event.js b/ghost/admin/app/helpers/parse-audit-log-event.js index 8df9475916..aad9e9875e 100644 --- a/ghost/admin/app/helpers/parse-audit-log-event.js +++ b/ghost/admin/app/helpers/parse-audit-log-event.js @@ -8,11 +8,15 @@ export default class ParseAuditLogEvent extends Helper { const action = getAction(ev); const actionIcon = getActionIcon(ev); const getActor = () => this.store.findRecord('user', ev.actor_id, {reload: false}); + const getResource = () => this.store.findRecord(ev.resource_type, ev.resource_id, {reload: false}); return { get actor() { return getActor(); }, + get resource() { + return getResource(); + }, actionIcon, action, original: ev diff --git a/ghost/admin/app/templates/settings/audit-log.hbs b/ghost/admin/app/templates/settings/audit-log.hbs index 4d46587972..cc4b075f94 100644 --- a/ghost/admin/app/templates/settings/audit-log.hbs +++ b/ghost/admin/app/templates/settings/audit-log.hbs @@ -9,61 +9,62 @@
{{#let (audit-log-event-fetcher pageSize=50) as |eventsFetcher|}} {{#if eventsFetcher.data}} -
- - - - - - - - - - {{#each eventsFetcher.data as |event|}} - {{#let (parse-audit-log-event event) as |ev|}} - -
-
-
-

{{ev.actor.name}}

-
-
-
-
-
-
{{svg-jar ev.actionIcon}}
-
- - {{capitalize-first-letter ev.action}} {{ev.original.resource_id}} - -
-
-
-
{{moment-format ev.original.created_at "DD MMM YYYY HH:mm:ss"}}
- - {{/let}} - {{/each}} - -
UserActionTime
+
+ + + + + + + + + + {{#each eventsFetcher.data as |event|}} + {{#let (parse-audit-log-event event) as |ev|}} + +
+
+ + + +

{{ev.actor.name}}

+
+
+
+
+
{{svg-jar ev.actionIcon}}
+
+ + {{capitalize-first-letter ev.action}} {{ev.resource.title}} + +
+
+
+
{{moment-format ev.original.created_at "DD MMM YYYY HH:mm:ss"}}
+ + {{/let}} + {{/each}} + +
UserActionTime
{{#if (not (or eventsFetcher.isLoading eventsFetcher.hasReachedEnd))}} - + {{/if}} -
+
{{else}} - {{#unless eventsFetcher.isLoading}} -
-
- {{svg-jar "activity-placeholder" class="gh-members-placeholder"}} -

No staff activity yet

-
-
- {{/unless}} - {{/if}} + {{#unless eventsFetcher.isLoading}} +
+
+ {{svg-jar "activity-placeholder" class="gh-members-placeholder"}} +

No staff activity yet

+
+
+ {{/unless}} + {{/if}} - {{#if eventsFetcher.isLoading}} -
- {{/if}} + {{#if eventsFetcher.isLoading}} +
+ {{/if}} {{/let}}