Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

🐛 Added tags sidebar navigation for editors

Browse source 
closes https://github.com/TryGhost/Ghost/issues/11882

- Editors have all the same permissions and access to tags as Owner/Admin roles, but had the sidebar navigation for tags missing
- Adds "Tags" to sidebar for Editor roles same as Owner/Admin
This commit is contained in:
Rish 2020-06-18 19:04:20 +05:30 • committed by Rishabh Garg
parent 6aefc005f8
commit 831fed23c6
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/components/gh-nav-menu.hbs
View file

@ -66,7 +66,7 @@
<LinkTo @route="pages" data-test-nav="pages">{{svg-jar "page"}}Pages</LinkTo> <LinkTo @route="pages" data-test-nav="pages">{{svg-jar "page"}}Pages</LinkTo>
{{/if}} {{/if}}
</li> </li>
{{#if (gh-user-can-admin this.session.user)}} {{#if this.showTagsNavigation}}
<li><LinkTo @route="tags" data-test-nav="tags">{{svg-jar "tag"}}Tags</LinkTo></li> <li><LinkTo @route="tags" data-test-nav="tags">{{svg-jar "tag"}}Tags</LinkTo></li>
{{/if}} {{/if}}
{{#if (and this.feature.members (gh-user-can-admin this.session.user))}} {{#if (and this.feature.members (gh-user-can-admin this.session.user))}}

3
ghost/admin/app/components/gh-nav-menu.js
View file

@ -2,7 +2,7 @@ import Component from '@ember/component';
import ShortcutsMixin from 'ghost-admin/mixins/shortcuts'; import ShortcutsMixin from 'ghost-admin/mixins/shortcuts';
import calculatePosition from 'ember-basic-dropdown/utils/calculate-position'; import calculatePosition from 'ember-basic-dropdown/utils/calculate-position';
import ctrlOrCmd from 'ghost-admin/utils/ctrl-or-cmd'; import ctrlOrCmd from 'ghost-admin/utils/ctrl-or-cmd';
import {and, equal, match} from '@ember/object/computed'; import {and, equal, match, or} from '@ember/object/computed';
import {computed} from '@ember/object'; import {computed} from '@ember/object';
import {getOwner} from '@ember/application'; import {getOwner} from '@ember/application';
import {htmlSafe} from '@ember/string'; import {htmlSafe} from '@ember/string';
@ -35,6 +35,7 @@ export default Component.extend(ShortcutsMixin, {
// be a bug in Ember that's preventing it from working immediately after login // be a bug in Ember that's preventing it from working immediately after login
isOnSite: equal('router.currentRouteName', 'site'), isOnSite: equal('router.currentRouteName', 'site'),
showTagsNavigation: or('session.user.isOwnerOrAdmin', 'session.user.isEditor'),
showMenuExtension: and('config.clientExtensions.menu', 'session.user.isOwner'), showMenuExtension: and('config.clientExtensions.menu', 'session.user.isOwner'),
showDropdownExtension: and('config.clientExtensions.dropdown', 'session.user.isOwner'), showDropdownExtension: and('config.clientExtensions.dropdown', 'session.user.isOwner'),
showScriptExtension: and('config.clientExtensions.script', 'session.user.isOwner'), showScriptExtension: and('config.clientExtensions.script', 'session.user.isOwner'),