Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-15 03:01:37 -05:00
Code Issues Activity

🐛 Fixed member activity event filter (#16849)

Browse source 
closes https://github.com/TryGhost/Ghost/issues/16817

The member activity event filter was broken due to a recursion issue.
This commit changes the usage of a getter fn to a normal class method to
make the logic more performant and remove the recursion issue
This commit is contained in:
Michael Barrett 2023-05-23 14:44:49 +01:00 • committed by GitHub
parent 1f9818d9c8
commit 81e160c8d3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ghost/admin/app/components/members-activity/event-type-filter.js
View file

@ -18,8 +18,8 @@ export default class MembersActivityEventTypeFilter extends Component {
@service settings;
@service feature;
get availableEventTypes() {
const extended = ALL_EVENT_TYPES;
getAvailableEventTypes() {
const extended = [...ALL_EVENT_TYPES];
if (this.settings.commentsEnabled !== 'off') {
extended.push({event: 'comment_event', icon: 'filter-dropdown-comments', name: 'Comments', group: 'others'});
@ -40,12 +40,13 @@ export default class MembersActivityEventTypeFilter extends Component {
get eventTypes() {
const excludedEvents = (this.args.excludedEvents || '').split(',');
const availableEventTypes = this.getAvailableEventTypes();
return this.availableEventTypes.map((type, i) => ({
return availableEventTypes.map((type, i) => ({
event: type.event,
icon: type.icon,
name: type.name,
divider: this.needDivider(type, this.availableEventTypes[i - 1]),
divider: this.needDivider(type, availableEventTypes[i - 1]),
isSelected: !excludedEvents.includes(type.event)
}));
}