Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

🐛 Fixed error deleting post with comment replies

Browse source 
closes: https://github.com/TryGhost/Ghost/issues/15252

- comments are deleted when posts are deleted. Without cascade delete on parent_id, replies cannot be deleted
- this change means that deleting a post will delete all comments and replies without error
This commit is contained in:
Hannah Wolfe 2022-08-19 15:24:51 +01:00
parent 6fe1b4a0dd
commit 809c1a6e08
3 changed files with 47 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
ghost/core/core/server/data/migrations/versions/5.10/2022-08-19-14-15-fix-comments-deletion-strategy.js Normal file
View file

@ -0,0 +1,45 @@
const {addForeign, dropForeign} = require('../../../schema/commands');
const logging = require('@tryghost/logging');
const {createTransactionalMigration} = require('../../utils');
module.exports = createTransactionalMigration(
async function up(knex) {
logging.info('Adding on delete CASCADE for comments parent_id');
await dropForeign({
fromTable: 'comments',
fromColumn: 'parent_id',
toTable: 'comments',
toColumn: 'id',
transaction: knex
});
await addForeign({
fromTable: 'comments',
fromColumn: 'parent_id',
toTable: 'comments',
toColumn: 'id',
cascadeDelete: true,
transaction: knex
});
},
async function down(knex) {
logging.info('Restoring foreign key for comments parent_id');
await dropForeign({
fromTable: 'comments',
fromColumn: 'parent_id',
toTable: 'comments',
toColumn: 'id',
transaction: knex
});
await addForeign({
fromTable: 'comments',
fromColumn: 'parent_id',
toTable: 'comments',
toColumn: 'id',
transaction: knex
});
}
);

2
ghost/core/core/server/data/schema/schema.js
View file

@ -773,7 +773,7 @@ module.exports = {
id: {type: 'string', maxlength: 24, nullable: false, primary: true},
post_id: {type: 'string', maxlength: 24, nullable: false, unique: false, references: 'posts.id', cascadeDelete: true},
member_id: {type: 'string', maxlength: 24, nullable: true, unique: false, references: 'members.id', setNullDelete: true},
parent_id: {type: 'string', maxlength: 24, nullable: true, unique: false, references: 'comments.id'},
parent_id: {type: 'string', maxlength: 24, nullable: true, unique: false, references: 'comments.id', cascadeDelete: true},
status: {type: 'string', maxlength: 50, nullable: false, defaultTo: 'published', validations: {isIn: [['published', 'hidden', 'deleted']]}},
html: {type: 'text', maxlength: 1000000000, fieldtype: 'long', nullable: true},
edited_at: {type: 'dateTime', nullable: true},

2
ghost/core/test/unit/server/data/schema/integrity.test.js
View file

@ -35,7 +35,7 @@ const validateRouteSettings = require('../../../../../core/server/services/route
*/
describe('DB version integrity', function () {
// Only these variables should need updating
const currentSchemaHash = 'ec9f46178cb70d3297d266203659ef4c';
const currentSchemaHash = 'ebc73ecd26ac795c34eaec6d8ec06304';
const currentFixturesHash = '0ae1887dd0b42508be946bdbd20d41c8';
const currentSettingsHash = 'd54210758b7054e2174fd34aa2320ad7';
const currentRoutesHash = '3d180d52c663d173a6be791ef411ed01';