Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-25 02:31:59 -05:00
Code Issues Activity

Added Beta label to recommendations settings

Browse source 
refs https://github.com/TryGhost/Product/issues/4068
This commit is contained in:
Djordje Vlaisavljevic 2023-10-25 18:15:21 +01:00
parent 75302ee184
commit 807e613386
3 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apps/admin-x-settings/src/admin-x-ds/settings/SettingGroup.tsx
View file

@ -18,6 +18,7 @@ interface SettingGroupProps {
saveState?: SaveState;
customHeader?: React.ReactNode;
customButtons?: React.ReactNode;
beta?: boolean;
children?: React.ReactNode;
hideEditButton?: boolean;
alwaysShowSaveButton?: boolean;
@ -52,6 +53,7 @@ const SettingGroup: React.FC<SettingGroupProps> = ({
saveState,
customHeader,
customButtons,
beta = false,
children,
hideEditButton,
alwaysShowSaveButton = true,
@ -178,7 +180,7 @@ const SettingGroup: React.FC<SettingGroupProps> = ({
<div className={containerClasses} data-testid={testId}>
<div ref={ref} className='absolute' id={navid && navid}></div>
{customHeader ? customHeader :
<SettingGroupHeader description={description} title={title!}>
<SettingGroupHeader beta={beta} description={description} title={title!}>
{customButtons ? customButtons :
(onEditingChange && <ButtonGroup buttons={isEditing ? editButtons : viewButtons} link linkWithPadding />)}
</SettingGroupHeader>

5
apps/admin-x-settings/src/admin-x-ds/settings/SettingGroupHeader.tsx
View file

@ -5,17 +5,18 @@ import {useSearch} from '../../components/providers/ServiceProvider';
interface Props {
title?: string;
description?: React.ReactNode;
beta?: boolean;
children?: React.ReactNode;
}
const SettingGroupHeader: React.FC<Props> = ({title, description, children}) => {
const SettingGroupHeader: React.FC<Props> = ({title, description, children, beta = false}) => {
const {highlightKeywords} = useSearch();
return (
<div className="flex items-start justify-between gap-4">
{(title || description) &&
<div>
<Heading level={5}>{highlightKeywords(title || '')}</Heading>
<Heading level={5}>{highlightKeywords(title || '')}{beta && <sup className='ml-0.5 text-[10px] font-semibold uppercase tracking-wide'>Beta</sup>}</Heading>
{description && <p className="mt-1 hidden max-w-lg group-[.is-not-editing]/setting-group:!visible group-[.is-not-editing]/setting-group:!block md:!visible md:!block">{highlightKeywords(description)}</p>}
</div>
}

1
apps/admin-x-settings/src/components/settings/membership/Recommendations.tsx
View file

@ -122,6 +122,7 @@ const Recommendations: React.FC<{ keywords: string[] }> = ({keywords}) => {
return (
<SettingGroup
beta={true}
customButtons={buttons}
description={groupDescription}
keywords={keywords}