Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

🎨 escape sameAs for structured data (#7833)

Browse source 
closes #7832

- escape output for json-ld
This commit is contained in:
Katharina Irrgang 2017-01-10 13:21:37 +01:00 committed by Kevin Ansfield
parent 7cd13e6122
commit 8031102596
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/server/data/meta/schema.js
View file

@ -41,7 +41,7 @@ function trimSameAs(data, context) {
if (context === 'post') {
if (data.post.author.website) {
sameAs.push(data.post.author.website);
sameAs.push(escapeExpression(data.post.author.website));
}
if (data.post.author.facebook) {
sameAs.push(socialUrls.facebookUrl(data.post.author.facebook));
@ -51,7 +51,7 @@ function trimSameAs(data, context) {
}
} else if (context === 'author') {
if (data.author.website) {
sameAs.push(data.author.website);
sameAs.push(escapeExpression(data.author.website));
}
if (data.author.facebook) {
sameAs.push(socialUrls.facebookUrl(data.author.facebook));

4
core/test/unit/metadata/schema_spec.js
View file

@ -437,7 +437,7 @@ describe('getSchema', function () {
context: ['author'],
author: {
name: 'Author Name',
website: 'http://myblogsite.com/',
website: 'http://myblogsite.com/?user=bambedibu&a=<script>alert("bambedibu")</script>',
twitter: '@testuser'
}
}, schema = getSchema(metadata, data);
@ -452,7 +452,7 @@ describe('getSchema', function () {
},
name: 'Author Name',
sameAs: [
'http://myblogsite.com/',
'http://myblogsite.com/?user&#x3D;bambedibu&amp;a&#x3D;&lt;script&gt;alert(&quot;bambedibu&quot;)&lt;/script&gt;',
'https://twitter.com/testuser'
],
url: 'http://mysite.com/author/me/'