From 7f6a25272169134682473c21dc905c59b25f55f9 Mon Sep 17 00:00:00 2001
From: Sanne de Vries <65487235+sanne-san@users.noreply.github.com>
Date: Mon, 6 Nov 2023 14:56:24 +0100
Subject: [PATCH] =?UTF-8?q?Removed=20feature=20image=20indicator=20and=20i?=
 =?UTF-8?q?mproved=20visibility=20of=20feature=20im=E2=80=A6=20(#18877)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

…age button

No ref
---
 ghost/admin/app/components/gh-editor-feature-image.hbs | 8 +-------
 ghost/admin/app/components/gh-editor-feature-image.js  | 5 -----
 ghost/admin/app/styles/layouts/editor.css              | 1 +
 3 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/ghost/admin/app/components/gh-editor-feature-image.hbs b/ghost/admin/app/components/gh-editor-feature-image.hbs
index 4d718a18b4..aaf68c256a 100644
--- a/ghost/admin/app/components/gh-editor-feature-image.hbs
+++ b/ghost/admin/app/components/gh-editor-feature-image.hbs
@@ -1,8 +1,6 @@
 {{!-- template-lint-disable no-invalid-interactive --}}
 <div
     class="gh-editor-feature-image-container"
-    {{on "mouseover" (fn (mut this.isHovered) true)}}
-    {{on "mouseleave" (fn (mut this.isHovered) false)}}
 >
 {{!-- template-lint-enable no-invalid-interactive --}}
     <GhUploader
@@ -40,10 +38,6 @@
                 <span class="gh-editor-hidden-indicator" data-tooltip="Feature image and post title are hidden on page">
                     {{svg-jar "eye-closed"}}
                 </span>
-            {{else}}
-                <span class="gh-editor-feature-image-indicator" data-tooltip="A feature image is publicly visible to anyone">
-                    {{svg-jar "feature-image"}}
-                </span>
             {{/if}}
             <div class="gh-editor-feature-image">
                 <img src={{@image}} alt={{@alt}} role={{if @alt "img" "presentation"}} class="{{if @isHidden "faded"}}">
@@ -87,7 +81,7 @@
             </div>
         {{else}}
             {{!-- no-image state --}}
-            <div class="flex flex-row items-center {{if this.hideButton "invisible"}}">
+            <div class="flex flex-row items-center">
                 {{#if this.canDrop}}
                     <div class="gh-editor-feature-image-add-button"><span>Drop to upload feature image</span></div>
                 {{else}}
diff --git a/ghost/admin/app/components/gh-editor-feature-image.js b/ghost/admin/app/components/gh-editor-feature-image.js
index b29eb98e32..0bc821093d 100644
--- a/ghost/admin/app/components/gh-editor-feature-image.js
+++ b/ghost/admin/app/components/gh-editor-feature-image.js
@@ -15,15 +15,10 @@ export default class GhEditorFeatureImageComponent extends Component {
     @service settings;
 
     @tracked isEditingAlt = false;
-    @tracked isHovered = false;
     @tracked captionInputFocused = false;
     @tracked showUnsplashSelector = false;
     @tracked canDrop = false;
 
-    get hideButton() {
-        return !this.canDrop && !this.isHovered && !this.args.forceButtonDisplay;
-    }
-
     get caption() {
         const content = this.args.caption;
         if (!content) {
diff --git a/ghost/admin/app/styles/layouts/editor.css b/ghost/admin/app/styles/layouts/editor.css
index 605a7b4b8d..8a08caec5d 100644
--- a/ghost/admin/app/styles/layouts/editor.css
+++ b/ghost/admin/app/styles/layouts/editor.css
@@ -593,6 +593,7 @@ body[data-user-is-dragging] .gh-editor-feature-image-dropzone {
     width: 1em;
     height: 1em;
     margin-left: 24px;
+    margin-bottom: 2px;
     line-height: 1.2;
 }