Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-08 02:52:39 -05:00
Code Issues Activity

Fixed skipped test for fetching setting by group

Browse source 
no issue

- The test was skipped, which should not have been commited into the trunk in the first place. The checks were reworked to reflect the reality - the endpoint ignores the "group" qurey parameter
This commit is contained in:
Naz 2021-05-24 11:39:02 +04:00
parent e03f99a8f3
commit 7ea91df628
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
test/regression/api/v2/admin/settings_spec.js
View file

@ -154,7 +154,7 @@ describe('Settings API (v2)', function () {
});
});
xit('Can not request settings by group, returns all settings instead', function () {
it('Can not request settings by group, returns all settings instead', function () {
return request.get(localUtils.API.getApiQuery(`settings/?group=theme`))
.set('Origin', config.get('url'))
.expect('Content-Type', /json/)
@ -170,8 +170,8 @@ describe('Settings API (v2)', function () {
jsonResponse.settings.should.be.an.Object();
const settings = jsonResponse.settings;
Object.keys(settings).length.should.equal(39);
settings.map(s => s.key).should.deepEqual(defaultSettingsKeyTypes);
Object.keys(settings).length.should.equal(defaultSettingsKeyTypes.length);
settings.map(s => s.key).sort().should.eql(defaultSettingsKeyTypes.map(s => s.key).sort());
localUtils.API.checkResponse(jsonResponse, 'settings');
});