From 7c188ec1ebdd0e5ae936e0f7252e345d703595e8 Mon Sep 17 00:00:00 2001 From: Fabien O'Carroll Date: Tue, 2 Jun 2020 18:58:30 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20settings=20controller=20?= =?UTF-8?q?edit=20method?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit no-issue This was because the API was recieving a default `null` value for the stripe_connect_integration_token setting. This also improves the logging for this error. --- core/server/api/canary/settings.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/server/api/canary/settings.js b/core/server/api/canary/settings.js index 0336c8aec3..f0d776f4de 100644 --- a/core/server/api/canary/settings.js +++ b/core/server/api/canary/settings.js @@ -131,7 +131,7 @@ module.exports = { } } - if (stripeConnectIntegrationToken) { + if (stripeConnectIntegrationToken && stripeConnectIntegrationToken.value) { const getSessionProp = prop => frame.original.session[prop]; try { const data = await membersService.stripeConnect.getStripeConnectTokenData(stripeConnectIntegrationToken.value, getSessionProp); @@ -141,6 +141,7 @@ module.exports = { }); } catch (err) { throw new BadRequestError({ + err, message: 'The Stripe Connect token could not be parsed.' }); }