Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Speed up 1.22 migration script (#9541)

Browse source 
no issue

- insert `posts_authors` relation via knex
- massive speed improvement

e.g. 1500 posts

- before: ~1min
- after: ~10sec
This commit is contained in:
Katharina Irrgang 2018-04-02 12:00:00 +02:00 • committed by GitHub
parent 3e33849e47
commit 7bbde460af
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
core/server/data/migrations/versions/1.22/1-multiple-authors-DML.js
View file

@ -2,6 +2,7 @@
const _ = require('lodash'),
Promise = require('bluebird'),
ObjectId = require('bson-objectid'),
common = require('../../../../lib/common'),
models = require('../../../../models');
@ -24,25 +25,24 @@ module.exports.up = function handleMultipleAuthors(options) {
common.logging.info('Adding `posts_authors` relations');
return Promise.map(posts.models, function (post) {
let authorIdToSet;
// CASE: ensure `post.author_id` is a valid user id
return models.User.findOne({id: post.get('author_id')}, _.merge({columns: userColumns}, localOptions))
.then(function (user) {
if (!user) {
authorIdToSet = ownerUser.id;
} else {
authorIdToSet = post.get('author_id');
return models.Post.edit({
author_id: ownerUser.id
}, _.merge({id: post.id}, localOptions));
}
return post;
})
.then(function () {
// CASE: insert primary author
return models.Post.edit({
author_id: authorIdToSet,
authors: [{
id: post.get('author_id')
}]
}, _.merge({id: post.id}, localOptions));
.then(function (post) {
return options.transacting('posts_authors').insert({
id: ObjectId.generate(),
post_id: post.id,
author_id: post.get('author_id'),
sort_order: 0
});
});
}, {concurrency: 100});
});