diff --git a/ghost/admin/app/components/gh-members-email-setting.hbs b/ghost/admin/app/components/gh-members-email-setting.hbs index 804dddb71b..66e094915b 100644 --- a/ghost/admin/app/components/gh-members-email-setting.hbs +++ b/ghost/admin/app/components/gh-members-email-setting.hbs @@ -194,13 +194,6 @@ -{{#if this.showLeaveSettingsModal}} - -{{/if}} - {{#if this.showEmailDesignSettings}} { + if (transition.to.queryParams?.fromAddressUpdate === 'success') { + this.notifications.showAlert( + `Newsletter email address has been updated`.htmlSafe(), + {type: 'success', key: 'members.settings.from-address.updated'} + ); + } else if (transition.to.queryParams?.supportAddressUpdate === 'success') { + this.notifications.showAlert( + `Support email address has been updated`.htmlSafe(), + {type: 'success', key: 'members.settings.support-address.updated'} + ); + } + }); }, model() { @@ -26,22 +31,12 @@ export default AuthenticatedRoute.extend(CurrentUserSettings, { }, setupController(controller) { - if (controller.fromAddressUpdate === 'success') { - this.notifications.showAlert( - `Newsletter email address has been updated`.htmlSafe(), - {type: 'success', key: 'members.settings.from-address.updated'} - ); - } else if (controller.supportAddressUpdate === 'success') { - this.notifications.showAlert( - `Support email address has been updated`.htmlSafe(), - {type: 'success', key: 'members.settings.support-address.updated'} - ); - } + controller.resetEmailAddresses(); }, - resetController(controller, isExiting) { - if (isExiting) { - controller.reset(); + actions: { + willTransition(transition) { + return this.controller.leaveRoute(transition); } }, diff --git a/ghost/admin/app/templates/settings/members-email.hbs b/ghost/admin/app/templates/settings/members-email.hbs index 85c185730a..170f349478 100644 --- a/ghost/admin/app/templates/settings/members-email.hbs +++ b/ghost/admin/app/templates/settings/members-email.hbs @@ -24,10 +24,19 @@ @settings={{this.settings}} @fromAddress={{this.fromAddress}} @supportAddress={{this.supportAddress}} - @setEmailAddress={{action "setEmailAddress"}} + @setEmailAddress={{this.setEmailAddress}} /> {{/if}} + + {{#if this.showLeaveSettingsModal}} + + {{/if}} \ No newline at end of file