Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-17 23:44:39 -05:00
Code Issues Activity

Fixed newsletter settings tests

Browse source 
refs a4ca693871

- label's "for" was removed to enable more direct use of the checkbox enabling keyboard usage but the test was not updated to reflect the change
This commit is contained in:
Kevin Ansfield 2022-03-31 11:37:38 +01:00
parent a4ca693871
commit 78e08af003
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/components/settings/members-email-labs.hbs
View file

@ -236,7 +236,7 @@
<p class="gh-expandable-description">Track how many members are reading your emails</p>
</div>
<div class="for-switch">
<label class="switch">
<label class="switch" data-test-label="email-track-opens">
<input
id="email-track-opens"
type="checkbox"

2
ghost/admin/tests/acceptance/settings/members-email-labs-test.js
View file

@ -38,7 +38,7 @@ describe('Acceptance: Settings - Members email (multipleNewsletters)', function
await visit('/settings/members-email-labs');
expect(find('[data-test-checkbox="email-track-opens"]')).to.be.checked;
await click('label[for="email-track-opens"]');
await click('[data-test-label="email-track-opens"]');
expect(find('[data-test-checkbox="email-track-opens"]')).to.not.be.checked;
await click('[data-test-button="save-members-settings"]');