Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-01 02:41:39 -05:00
Code Issues Activity

Refactored Sentry beforeSend code

Browse source 
- this tidies up the implementation by removing the very verbose ternary
  operator, and also uses the optional chaining operator
This commit is contained in:
Daniel Lockyer 2024-05-08 14:09:11 +02:00 • committed by Daniel Lockyer
parent c4ad593a5a
commit 77fc66340a
1 changed files with 12 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
ghost/core/core/shared/sentry.js
View file

@ -12,17 +12,17 @@ const errors = require('@tryghost/errors');
const beforeSend = function (event, hint) {
try {
const exception = hint.originalException;
const code = (exception && exception.code) ? exception.code : null;
const context = (exception && exception.context) ? exception.context : null;
const errorType = (exception && exception.errorType) ? exception.errorType : null;
const id = (exception && exception.id) ? exception.id : null;
const statusCode = (exception && exception.statusCode) ? exception.statusCode : null;
const code = exception?.code ?? null;
const context = exception?.context ?? null;
const errorType = exception?.errorType ?? null;
const id = exception?.id ?? null;
const statusCode = exception?.statusCode ?? null;
event.tags = event.tags || {};
if (errors.utils.isGhostError(exception)) {
// Unexpected errors have a generic error message, set it back to context if there is one
if (code === 'UNEXPECTED_ERROR' && context !== null) {
if (event.exception.values && event.exception.values.length > 0) {
if (event.exception.values?.length > 0) {
event.exception.values[0].type = context;
}
}
@ -30,11 +30,12 @@ const beforeSend = function (event, hint) {
// This is a mysql2 error — add some additional context
if (exception.sql) {
const sql = exception.sql;
const errno = exception.errno ? exception.errno : null;
const sqlErrorCode = exception.sqlErrorCode ? exception.sqlErrorCode : null;
const sqlMessage = exception.sqlMessage ? exception.sqlMessage : null;
const sqlState = exception.sqlState ? exception.sqlState : null;
if (event.exception.values && event.exception.values.length > 0) {
const errno = exception.errno ?? null;
const sqlErrorCode = exception.sqlErrorCode ?? null;
const sqlMessage = exception.sqlMessage ?? null;
const sqlState = exception.sqlState ?? null;
if (event.exception.values?.length > 0) {
event.exception.values[0].type = `SQL Error ${errno}: ${sqlErrorCode}`;
event.exception.values[0].value = sqlMessage;
event.contexts = event.contexts || {};